Skip to content

test: fix test-heapdump-zlib#34499

Closed
puzpuzpuz wants to merge 2 commits into
nodejs:masterfrom
puzpuzpuz:fix/broken-pummel-test-for-zlib
Closed

test: fix test-heapdump-zlib#34499
puzpuzpuz wants to merge 2 commits into
nodejs:masterfrom
puzpuzpuz:fix/broken-pummel-test-for-zlib

Conversation

@puzpuzpuz
Copy link
Copy Markdown
Member

@puzpuzpuz puzpuzpuz commented Jul 23, 2020

Refs: #34048

Fixes test/pummel/test-heapdump-zlib.js which was broken by #34048.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
@puzpuzpuz puzpuzpuz added zlib Issues and PRs related to the zlib subsystem. test Issues and PRs related to the tests. labels Jul 23, 2020
@puzpuzpuz puzpuzpuz force-pushed the fix/broken-pummel-test-for-zlib branch from 50910cb to 42a4793 Compare July 23, 2020 20:29
@puzpuzpuz puzpuzpuz mentioned this pull request Jul 23, 2020
Closed
4 tasks
@puzpuzpuz puzpuzpuz force-pushed the fix/broken-pummel-test-for-zlib branch from 42a4793 to 6b6841c Compare July 23, 2020 20:32
@puzpuzpuz puzpuzpuz changed the title test: fix pummel zlib test test: fix test-heapdump-zlib Jul 23, 2020
richardlau
richardlau reviewed Jul 23, 2020
View reviewed changes
Comment thread test/pummel/test-heapdump-zlib.js Outdated
@puzpuzpuz puzpuzpuz force-pushed the fix/broken-pummel-test-for-zlib branch from 6b6841c to 35d87dc Compare July 23, 2020 20:38
@puzpuzpuz puzpuzpuz force-pushed the fix/broken-pummel-test-for-zlib branch from 35d87dc to e2fef24 Compare July 23, 2020 20:40
@richardlau
Copy link
Copy Markdown
Member

richardlau commented Jul 23, 2020

I've requested a pummel CI run (queued): https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/15556/
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@richardlau
Copy link
Copy Markdown
Member

richardlau commented Jul 23, 2020

If the CI's come back green I'd suggest fast tracking to unbreak the daily builds.
@addaleax addaleax added the fast-track PRs that do not need to wait for 72 hours to land. label Jul 23, 2020
Trott
Trott reviewed Jul 23, 2020
View reviewed changes
Comment thread test/pummel/test-heapdump-zlib.js Outdated
@Trott
Copy link
Copy Markdown
Member

Trott commented Jul 23, 2020 •
edited
Loading

Pummel CI re-run: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/15561/ ✅
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Jul 23, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/32496/
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Jul 24, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/32497/
@github-actions github-actions Bot mentioned this pull request Jul 24, 2020
Open
6 tasks
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Jul 24, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/32498/
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Jul 24, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/32499/
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Jul 24, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/32502/
Trott pushed a commit that referenced this pull request Jul 24, 2020
@puzpuzpuz @Trott
test: fix test-heapdump-zlib
d1e4e8e 
PR-URL: #34499
Refs: #34048
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott
Copy link
Copy Markdown
Member

Trott commented Jul 24, 2020

Landed in d1e4e8e

Thanks for the quick fix!
@Trott Trott closed this Jul 24, 2020
@puzpuzpuz puzpuzpuz deleted the fix/broken-pummel-test-for-zlib branch July 24, 2020 06:58
This was referenced Jul 25, 2020
Open
Open
Open
MylesBorins pushed a commit that referenced this pull request Jul 27, 2020
@puzpuzpuz @MylesBorins
test: fix test-heapdump-zlib
3f11ba1 
PR-URL: #34499
Refs: #34048
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@github-actions github-actions Bot mentioned this pull request Jul 28, 2020
Open
3 tasks
@ruyadorno ruyadorno mentioned this pull request Jul 28, 2020
Merged
This was referenced Jul 29, 2020
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@puzpuzpuz @addaleax
test: fix test-heapdump-zlib
aa576eb 
PR-URL: #34499
Refs: #34048
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@puzpuzpuz @addaleax
test: fix test-heapdump-zlib
afd6e46 
PR-URL: #34499
Refs: #34048
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Merged
@mhdawson mhdawson mentioned this pull request Jan 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-track PRs that do not need to wait for 72 hours to land. test Issues and PRs related to the tests. zlib Issues and PRs related to the zlib subsystem.

5 participants

@puzpuzpuz @richardlau @nodejs-github-bot @Trott @addaleax