Skip to content

deps: patch V8 to 8.1.307.31#33080

Closed
targos wants to merge 1 commit into
nodejs:masterfrom
targos:patchv8
Closed

deps: patch V8 to 8.1.307.31#33080
targos wants to merge 1 commit into
nodejs:masterfrom
targos:patchv8

Conversation

@targos
Copy link
Copy Markdown
Member

@targos targos commented Apr 26, 2020

@nodejs-github-bot nodejs-github-bot added the v8 engine Issues and PRs related to the V8 dependency. label Apr 26, 2020
@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 27, 2020
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Apr 27, 2020

@bricss bricss mentioned this pull request Apr 28, 2020
@addaleax
Copy link
Copy Markdown
Member

Fast-track this because including it in v14.1.0 (#33103) has been requested and it’s only a few hours anyway? I’m okay with that.

@addaleax addaleax added the fast-track PRs that do not need to wait for 72 hours to land. label Apr 28, 2020
@targos
Copy link
Copy Markdown
Member Author

targos commented Apr 28, 2020

no objections

addaleax pushed a commit that referenced this pull request Apr 28, 2020
Refs: v8/v8@8.1.307.30...8.1.307.31

PR-URL: #33080
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
@addaleax
Copy link
Copy Markdown
Member

Landed in 563efb7

@addaleax addaleax closed this Apr 28, 2020
@targos targos deleted the patchv8 branch April 28, 2020 13:59
BethGriggs pushed a commit that referenced this pull request Apr 28, 2020
Refs: v8/v8@8.1.307.30...8.1.307.31

PR-URL: #33080
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
BethGriggs pushed a commit that referenced this pull request Apr 28, 2020
Refs: v8/v8@8.1.307.30...8.1.307.31

PR-URL: #33080
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
@targos targos added dont-land-on-v10.x and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-track PRs that do not need to wait for 72 hours to land. v8 engine Issues and PRs related to the V8 dependency.

6 participants