Skip to content

test: remove util properties from common#3304

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:goodbye-util
Closed

test: remove util properties from common#3304
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:goodbye-util

Conversation

@Trott
Copy link
Copy Markdown
Member

@Trott Trott commented Oct 9, 2015

common does not need util properties anymore. Remove them.

common does not need util properties anymore. Remove them.
@Trott Trott added the test Issues and PRs related to the tests. label Oct 9, 2015
@Trott
Copy link
Copy Markdown
Member Author

Trott commented Oct 9, 2015

@Fishrock123
Copy link
Copy Markdown
Contributor

LGTM if CI is happy

@brendanashworth
Copy link
Copy Markdown
Contributor

LGTM too.

@thefourtheye
Copy link
Copy Markdown
Contributor

LGTM

@Trott
Copy link
Copy Markdown
Member Author

Trott commented Oct 12, 2015

Landed in 3202456

@Trott Trott closed this Oct 12, 2015
Trott added a commit that referenced this pull request Oct 12, 2015
common does not need util properties anymore. Remove them.

PR-URL: #3304
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Brendan Ashworth <brendan.ashworth@me.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Trott added a commit that referenced this pull request Oct 28, 2015
common does not need util properties anymore. Remove them.

PR-URL: #3304
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Brendan Ashworth <brendan.ashworth@me.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@jasnell
Copy link
Copy Markdown
Member

jasnell commented Oct 28, 2015

Landed in v4.x-staging in 4c411ae

Trott added a commit that referenced this pull request Oct 29, 2015
common does not need util properties anymore. Remove them.

PR-URL: #3304
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Brendan Ashworth <brendan.ashworth@me.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@Trott Trott deleted the goodbye-util branch January 13, 2022 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test Issues and PRs related to the tests.

5 participants