chore: removed unused error code#32481
Closed
yashLadha wants to merge 1 commit into
Closed
Conversation
himself65
requested changes
Mar 25, 2020
Member
himself65
left a comment
himself65
left a comment
There was a problem hiding this comment.
commit message should be lib: removed unused error code
yashLadha
force-pushed
the
chore/remove_unused_import
branch
from
b95464e to
0d07b6f
Compare
addaleax
approved these changes
Mar 25, 2020
jasnell
approved these changes
Mar 25, 2020
lpinca
approved these changes
Mar 25, 2020
addaleax
added
the
author ready
Collaborator
Collaborator
Collaborator
Member
|
Landed in a5e81e7 |
addaleax
pushed a commit
that referenced
this pull request
Mar 30, 2020
PR-URL: #32481 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Mar 30, 2020
PR-URL: #32481 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
added
backport-blocked-v12.x
and removed
author ready
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 25, 2020
PR-URL: nodejs#32481 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 28, 2020
PR-URL: #32481 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed an unused error code, as the value is not read anywhere else.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes