net: shallow copy option when create Server#28924
Closed
himself65 wants to merge 1 commit into
Closed
Conversation
ChALkeR
reviewed
Aug 1, 2019
himself65
force-pushed
the
refactor-net-Server
branch
from
3f733a4 to
96f27db
Compare
addaleax
approved these changes
Aug 1, 2019
cjihrig
approved these changes
Aug 1, 2019
shisama
approved these changes
Aug 1, 2019
jasnell
approved these changes
Aug 1, 2019
lpinca
approved these changes
Aug 1, 2019
ChALkeR
approved these changes
Aug 1, 2019
Trott
approved these changes
Aug 4, 2019
Collaborator
Member
|
Landed in d530354 |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Aug 4, 2019
PR-URL: nodejs#28924 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
BridgeAR
pushed a commit
that referenced
this pull request
Aug 6, 2019
PR-URL: #28924 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes