test: add mustCall to test-dgram-connect-send-callback-buffer#27466
Closed
shenchenxh wants to merge 1 commit into
Closed
test: add mustCall to test-dgram-connect-send-callback-buffer#27466shenchenxh wants to merge 1 commit into
shenchenxh wants to merge 1 commit into
Conversation
ZYSzys
approved these changes
Apr 28, 2019
ZYSzys
added
the
code-and-learn
gireeshpunathil
approved these changes
Apr 28, 2019
Member
|
please leave 👍 to fast track |
Collaborator
cjihrig
approved these changes
Apr 28, 2019
Collaborator
oyyd
approved these changes
Apr 28, 2019
Collaborator
Collaborator
Contributor
|
The CI is actually green now: https://ci.nodejs.org/job/node-test-pull-request/22795/ (The test |
oyyd
pushed a commit
that referenced
this pull request
Apr 29, 2019
PR-URL: #27466 Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
Contributor
|
Landed in 77b9007, thanks! You can visit https://www.nodetodo.org/next-steps/ for more ideas to contribute. |
targos
pushed a commit
that referenced
this pull request
Apr 29, 2019
PR-URL: #27466 Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
Merged
This was referenced May 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes