Skip to content

build: DTrace is enabled by default on darwin#2019

Merged
evanlucas merged 1 commit into
nodejs:masterfrom
evanlucas:dtrace_config
Jun 23, 2015
Merged

build: DTrace is enabled by default on darwin#2019
evanlucas merged 1 commit into
nodejs:masterfrom
evanlucas:dtrace_config

Conversation

@evanlucas
Copy link
Copy Markdown
Contributor

In configure, the --with-dtrace option only showed that it was true by
default on sunos. It is also true by default on darwin.

@mscdex mscdex added the build Issues and PRs related to build files or the CI. label Jun 19, 2015
@rvagg
Copy link
Copy Markdown
Member

rvagg commented Jun 21, 2015

/cc @nodejs/build

@jbergstroem
Copy link
Copy Markdown
Member

LGTM

In configure, the --with-dtrace option only showed that it was true by
default on sunos. It is also true by default on darwin.

PR-URL: nodejs#2019
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
@evanlucas evanlucas closed this Jun 23, 2015
@evanlucas evanlucas deleted the dtrace_config branch June 23, 2015 16:28
@evanlucas evanlucas merged commit 834a365 into nodejs:master Jun 23, 2015
@evanlucas
Copy link
Copy Markdown
Contributor Author

Landed in 834a365. Thanks!

@rvagg rvagg mentioned this pull request Jun 30, 2015
mscdex pushed a commit to mscdex/io.js that referenced this pull request Jul 9, 2015
In configure, the --with-dtrace option only showed that it was true by
default on sunos. It is also true by default on darwin.

PR-URL: nodejs#2019
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues and PRs related to build files or the CI.

4 participants