Skip to content

doc: fix typo in http2.md#18872

Closed
vsemozhetbyt wants to merge 1 commit into
nodejs:masterfrom
vsemozhetbyt:doc-http2-type-typo
Closed

doc: fix typo in http2.md#18872
vsemozhetbyt wants to merge 1 commit into
nodejs:masterfrom
vsemozhetbyt:doc-http2-type-typo

Conversation

@vsemozhetbyt
Copy link
Copy Markdown
Contributor

@vsemozhetbyt vsemozhetbyt commented Feb 19, 2018 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc, http2
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem. labels Feb 19, 2018
@vsemozhetbyt vsemozhetbyt added the fast-track PRs that do not need to wait for 72 hours to land. label Feb 19, 2018
@vsemozhetbyt
Copy link
Copy Markdown
Contributor Author

vsemozhetbyt commented Feb 19, 2018

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/180/
@vsemozhetbyt vsemozhetbyt reopened this Feb 19, 2018
mhdawson
mhdawson approved these changes Feb 19, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@vsemozhetbyt
Copy link
Copy Markdown
Contributor Author

vsemozhetbyt commented Feb 19, 2018

Landed in 469036a
@vsemozhetbyt vsemozhetbyt deleted the doc-http2-type-typo branch February 19, 2018 22:03
vsemozhetbyt added a commit that referenced this pull request Feb 19, 2018
@vsemozhetbyt
doc: fix typo in http2.md
469036a 
PR-URL: #18872
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@vsemozhetbyt @MylesBorins
doc: fix typo in http2.md
6be701a 
PR-URL: #18872
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@MylesBorins MylesBorins mentioned this pull request Feb 21, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@vsemozhetbyt @MylesBorins
doc: fix typo in http2.md
e9766e3 
PR-URL: #18872
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@vsemozhetbyt @MylesBorins
doc: fix typo in http2.md
8047c27 
PR-URL: #18872
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
kjin pushed a commit to kjin/node that referenced this pull request May 1, 2018
@vsemozhetbyt @kjin
doc: fix typo in http2.md
7c2bc72 
PR-URL: nodejs#18872
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins pushed a commit that referenced this pull request May 2, 2018
@vsemozhetbyt @MylesBorins
doc: fix typo in http2.md
d85e5f4 
Backport-PR-URL: #20456
PR-URL: #18872
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@MylesBorins MylesBorins mentioned this pull request May 2, 2018
Merged
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@vsemozhetbyt @MayaLekova
doc: fix typo in http2.md
f251e9d 
PR-URL: nodejs#18872
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins pushed a commit that referenced this pull request May 15, 2018
@vsemozhetbyt @MylesBorins
doc: fix typo in http2.md
fe3c85f 
Backport-PR-URL: #20456
PR-URL: #18872
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins pushed a commit that referenced this pull request May 15, 2018
@vsemozhetbyt @MylesBorins
doc: fix typo in http2.md
27948fe 
Backport-PR-URL: #20456
PR-URL: #18872
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins pushed a commit that referenced this pull request May 15, 2018
@vsemozhetbyt @MylesBorins
doc: fix typo in http2.md
0829b54 
Backport-PR-URL: #20456
PR-URL: #18872
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins pushed a commit that referenced this pull request Jun 14, 2018
@vsemozhetbyt @MylesBorins
doc: fix typo in http2.md
9b10bd3 
Backport-PR-URL: #20456
PR-URL: #18872
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@MylesBorins MylesBorins mentioned this pull request Jul 9, 2018
Merged
rvagg pushed a commit that referenced this pull request Aug 16, 2018
@vsemozhetbyt @rvagg
doc: fix typo in http2.md
52f5829 
Backport-PR-URL: #20456
PR-URL: #18872
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 72 hours to land. http2 Issues or PRs related to the http2 subsystem.

4 participants

@vsemozhetbyt @cjihrig @mhdawson @nodejs-github-bot