Skip to content

deps: update nghttp2 to 1.29.0#17908

Closed
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:http2-update-1.29.0
Closed

deps: update nghttp2 to 1.29.0#17908
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:http2-update-1.29.0

Conversation

@jasnell
Copy link
Copy Markdown
Member

@jasnell jasnell commented Dec 28, 2017 •
edited
Loading

Update nghttp2 to 1.29.0

Significant changes since last update:

  • lib: Use NGHTTP2_REFUSED_STREAM for streams which are closed by GOAWAY
  • lib: Add nghttp2_error_callback2 (will be using this soon)

Refs: #17746

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

deps, nghttp2
@nodejs-github-bot nodejs-github-bot added dont-land-on-v4.x http2 Issues or PRs related to the http2 subsystem. labels Dec 28, 2017
@jasnell
Copy link
Copy Markdown
Member Author

jasnell commented Dec 28, 2017

ping @nodejs/http2
@jasnell jasnell mentioned this pull request Dec 28, 2017
Closed
11 tasks
@jasnell
Copy link
Copy Markdown
Member Author

jasnell commented Dec 28, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/12336/
cjihrig
cjihrig approved these changes Dec 28, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubberstamp LGTM
@mcollina
Copy link
Copy Markdown
Member

mcollina commented Dec 28, 2017

LGTM
@jasnell
Copy link
Copy Markdown
Member Author

jasnell commented Dec 29, 2017

CI looks good in general but something's up with the windows build bots.
@starkwang starkwang mentioned this pull request Dec 30, 2017
Closed
jasnell added a commit that referenced this pull request Dec 30, 2017
@jasnell
deps: update nghttp2 to 1.29.0
cfca536 
PR-URL: #17908
Refs: #17746
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@jasnell
Copy link
Copy Markdown
Member Author

jasnell commented Dec 30, 2017

Landed in cfca536
@jasnell jasnell closed this Dec 30, 2017
MylesBorins pushed a commit that referenced this pull request Jan 8, 2018
@jasnell @MylesBorins
deps: update nghttp2 to 1.29.0
428c9aa 
PR-URL: #17908
Refs: #17746
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 9, 2018
@jasnell @MylesBorins
deps: update nghttp2 to 1.29.0
430c9c2 
PR-URL: #17908
Refs: #17746
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 9, 2018
@jasnell @MylesBorins
deps: update nghttp2 to 1.29.0
5df8c76 
PR-URL: #17908
Refs: #17746
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jan 10, 2018
Merged
MylesBorins added a commit that referenced this pull request Jan 10, 2018
@MylesBorins
2019-01-10 Version 9.4.0 (Current)
074a2cb 
Notable change:

* async_hooks:
  - deprecate AsyncHooks Sensitive API and runInAsyncIdScope. Neither
    API were documented. (Andreas Madsen)
    #16972
* deps:
  - update nghttp2 to 1.29.0 (James M Snell)
    #17908
  - upgrade npm to 5.6.0 (Kat Marchán)
    #17535
  - cherry-pick 50f7455 from upstream V8 (Michaël Zasso)
    #16591
* events:
  - remove reaches into _events internals (Anatoli Papirovski)
    #17440
* http:
  - add rawPacket in err of `clientError` event (XadillaX)
    #17672
* http2:
  - implement maxSessionMemory (James M Snell)
    #17967
  - add initial support for originSet (James M Snell)
    #17935
  - add altsvc support (James M Snell)
    #17917
  - perf_hooks integration (James M Snell)
    #17906
* net:
  - remove Socket.prototype.write (Anna Henningsen)
    #17644
  - remove Socket.prototype.listen (Ruben Bridgewater)
    #13735
* repl:
  - show lexically scoped vars in tab completion (Michaël Zasso)
    #16591
* stream:
  - rm {writeable/readable}State.length (Calvin Metcalf)
    #12857
  - add flow and buffer properties to streams (Calvin Metcalf)
    #12855
* util:
  - allow wildcards in NODE_DEBUG variable (Tyler)
    #17609
* zlib:
  - add ArrayBuffer support (Jem Bezooyen)
    #16042
* Addedew collaborator**
  - [starkwang](https://github.com/starkwang) Weijia Wang
* Addedew TSC member**
  - [danbev](https://github.com/danbev) Daniel Bevenius

PR-URL: #18069
MylesBorins added a commit that referenced this pull request Jan 10, 2018
@MylesBorins
2019-01-10 Version 9.4.0 (Current)
7aefa40 
Notable change:

* async_hooks:
  - deprecate AsyncHooks Sensitive API and runInAsyncIdScope. Neither
    API were documented. (Andreas Madsen)
    #16972
* deps:
  - update nghttp2 to 1.29.0 (James M Snell)
    #17908
  - upgrade npm to 5.6.0 (Kat Marchán)
    #17535
  - cherry-pick 50f7455 from upstream V8 (Michaël Zasso)
    #16591
* events:
  - remove reaches into _events internals (Anatoli Papirovski)
    #17440
* http:
  - add rawPacket in err of `clientError` event (XadillaX)
    #17672
* http2:
  - implement maxSessionMemory (James M Snell)
    #17967
  - add initial support for originSet (James M Snell)
    #17935
  - add altsvc support (James M Snell)
    #17917
  - perf_hooks integration (James M Snell)
    #17906
  - Refactoring and cleanup of Http2Session and Http2Stream destroy
    (James M Snell) #17406
* net:
  - remove Socket.prototype.write (Anna Henningsen)
    #17644
  - remove Socket.prototype.listen (Ruben Bridgewater)
    #13735
* repl:
  - show lexically scoped vars in tab completion (Michaël Zasso)
    #16591
* stream:
  - rm {writeable/readable}State.length (Calvin Metcalf)
    #12857
  - add flow and buffer properties to streams (Calvin Metcalf)
    #12855
* util:
  - allow wildcards in NODE_DEBUG variable (Tyler)
    #17609
* zlib:
  - add ArrayBuffer support (Jem Bezooyen)
    #16042
* Addedew collaborator**
  - [starkwang](https://github.com/starkwang) Weijia Wang
* Addedew TSC member**
  - [danbev](https://github.com/danbev) Daniel Bevenius

PR-URL: #18069
MylesBorins added a commit that referenced this pull request Jan 10, 2018
@MylesBorins
2019-01-10 Version 9.4.0 (Current)
e688175 
Notable change:

* async_hooks:
  - deprecate AsyncHooks Sensitive API and runInAsyncIdScope. Neither
    API were documented. (Andreas Madsen)
    #16972
* deps:
  - update nghttp2 to 1.29.0 (James M Snell)
    #17908
  - upgrade npm to 5.6.0 (Kat Marchán)
    #17535
  - cherry-pick 50f7455 from upstream V8 (Michaël Zasso)
    #16591
* events:
  - remove reaches into _events internals (Anatoli Papirovski)
    #17440
* http:
  - add rawPacket in err of `clientError` event (XadillaX)
    #17672
* http2:
  - implement maxSessionMemory (James M Snell)
    #17967
  - add initial support for originSet (James M Snell)
    #17935
  - add altsvc support (James M Snell)
    #17917
  - perf_hooks integration (James M Snell)
    #17906
  - Refactoring and cleanup of Http2Session and Http2Stream destroy
    (James M Snell) #17406
* net:
  - remove Socket.prototype.write (Anna Henningsen)
    #17644
  - remove Socket.prototype.listen (Ruben Bridgewater)
    #13735
* repl:
  - show lexically scoped vars in tab completion (Michaël Zasso)
    #16591
* stream:
  - rm {writeable/readable}State.length (Calvin Metcalf)
    #12857
  - add flow and buffer properties to streams (Calvin Metcalf)
    #12855
* util:
  - allow wildcards in NODE_DEBUG variable (Tyler)
    #17609
* zlib:
  - add ArrayBuffer support (Jem Bezooyen)
    #16042
* Addedew collaborator**
  - [starkwang](https://github.com/starkwang) Weijia Wang
* Addedew TSC member**
  - [danbev](https://github.com/danbev) Daniel Bevenius

PR-URL: #18069
MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Apr 12, 2018
@jasnell @MylesBorins
deps: update nghttp2 to 1.29.0
ceb24c9 
PR-URL: nodejs#17908
Refs: nodejs#17746
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
kjin pushed a commit to kjin/node that referenced this pull request May 1, 2018
@jasnell @kjin
deps: update nghttp2 to 1.29.0
14d0bab 
PR-URL: nodejs#17908
Refs: nodejs#17746
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 2, 2018
@jasnell @MylesBorins
deps: update nghttp2 to 1.29.0
9acc7f3 
Backport-PR-URL: #20456
PR-URL: #17908
Refs: #17746
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@MylesBorins MylesBorins mentioned this pull request May 2, 2018
Merged
MylesBorins added a commit that referenced this pull request May 15, 2018
@MylesBorins
2018-05-15, Version 8.11.2 'Carbon' (LTS)
d747bc4 
Notable Changes:

deps:
  - update node-inspect to 1.11.3 (Jan Krems)
    #18354
  - update nghttp2 to 1.29.0 (James M Snell)
    #17908
http2:
  - Sync with current release stream
n-api:
  - Sync with current release stream

PR-URL: #20478
MylesBorins added a commit that referenced this pull request May 15, 2018
@MylesBorins
2018-05-15, Version 8.11.2 'Carbon' (LTS)
faf417b 
Notable Changes:

deps:
  - update node-inspect to 1.11.3 (Jan Krems)
    #18354
  - update nghttp2 to 1.29.0 (James M Snell)
    #17908
http2:
  - Sync with current release stream
n-api:
  - Sync with current release stream

PR-URL: #20478
MylesBorins added a commit that referenced this pull request May 15, 2018
@MylesBorins
2018-05-15, Version 8.11.2 'Carbon' (LTS)
2e7ea6e 
Notable Changes:

deps:
  - update node-inspect to 1.11.3 (Jan Krems)
    #18354
  - update nghttp2 to 1.29.0 (James M Snell)
    #17908
http2:
  - Sync with current release stream
n-api:
  - Sync with current release stream

PR-URL: #20478
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

http2 Issues or PRs related to the http2 subsystem.

6 participants

@jasnell @mcollina @addaleax @TimothyGu @cjihrig @nodejs-github-bot