src: fix compiler warning#17195
Closed
cjihrig wants to merge 1 commit into
Closed
Conversation
This commit fixes a -Winconsistent-missing-override warning.
nodejs-github-bot
added
c++
refack
approved these changes
Nov 21, 2017
jasnell
approved these changes
Nov 21, 2017
Member
|
This shouldn't need to wait the 48 hours to land once it passes CI |
Member
jasnell
pushed a commit
that referenced
this pull request
Nov 21, 2017
This commit fixes a -Winconsistent-missing-override warning. PR-URL: #17195 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
|
Landed in bb31a16 |
joyeecheung
added
the
fast-track
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
This commit fixes a -Winconsistent-missing-override warning. PR-URL: #17195 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
gibfahn
pushed a commit
that referenced
this pull request
Dec 19, 2017
This commit fixes a -Winconsistent-missing-override warning. PR-URL: #17195 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Closed
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
This commit fixes a -Winconsistent-missing-override warning. PR-URL: #17195 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes a -Winconsistent-missing-override warning.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
src