Skip to content

(v6.x backport) test: use ES6 classes instead of util.inherits#17068

Closed
tniessen wants to merge 1 commit into
nodejs:v6.x-stagingfrom
tniessen:backport-16938-to-v6.x
Closed

(v6.x backport) test: use ES6 classes instead of util.inherits#17068
tniessen wants to merge 1 commit into
nodejs:v6.x-stagingfrom
tniessen:backport-16938-to-v6.x

Conversation

@tniessen
Copy link
Copy Markdown
Member

@tniessen tniessen commented Nov 16, 2017

Backport of #16938 to v6.x.

Thanks to @MylesBorins for landing backport PRs required for this to land cleanly!
@tniessen
test: use ES6 classes instead of util.inherits
83169f0 
PR-URL: nodejs#16938
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@tniessen tniessen added test Issues and PRs related to the tests. v6.x labels Nov 16, 2017
@tniessen tniessen requested a review from MylesBorins November 16, 2017 11:53
@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. v6.x labels Nov 16, 2017
@tniessen
Copy link
Copy Markdown
Member Author

tniessen commented Nov 16, 2017

CI: https://ci.nodejs.org/job/node-test-commit/14073/
MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
@tniessen @MylesBorins
test: use ES6 classes instead of util.inherits
5793586 
Backport-PR-URL: #17068
PR-URL: #16938
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@MylesBorins
Copy link
Copy Markdown
Contributor

MylesBorins commented Nov 16, 2017

landed in 5793586
thanks!
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
@tniessen @MylesBorins
test: use ES6 classes instead of util.inherits
9944499 
Backport-PR-URL: #17068
PR-URL: #16938
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
@tniessen @MylesBorins
test: use ES6 classes instead of util.inherits
f2108fa 
Backport-PR-URL: #17068
PR-URL: #16938
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test Issues and PRs related to the tests.

3 participants

@tniessen @MylesBorins @nodejs-github-bot