Skip to content

doc: replace undocumented encoding aliases#16368

Closed
vsemozhetbyt wants to merge 1 commit into
nodejs:masterfrom
vsemozhetbyt:doc-fs-enc
Closed

doc: replace undocumented encoding aliases#16368
vsemozhetbyt wants to merge 1 commit into
nodejs:masterfrom
vsemozhetbyt:doc-fs-enc

Conversation

@vsemozhetbyt
Copy link
Copy Markdown
Contributor

Checklist
Affected core subsystem(s)

doc

Currently, we support utf-8 as an alias for utf8, but it is not documented. We document this for util.TextDecoder API, but it seems to be a different API. So maybe we can fix this fragments for consistency.

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 21, 2017
vsemozhetbyt added a commit that referenced this pull request Oct 22, 2017
PR-URL: #16368
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
@vsemozhetbyt
Copy link
Copy Markdown
Contributor Author

Landed in 93d1135

Thank you, @lingvoboard, for reporting this!

@MylesBorins
Copy link
Copy Markdown
Contributor

This does not land cleanly on 8.x

Could someone please backport

@vsemozhetbyt
Copy link
Copy Markdown
Contributor Author

Backport PR: #16421

MylesBorins pushed a commit that referenced this pull request Oct 24, 2017
Backport-PR-URL: #16421
PR-URL: #16368
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Oct 26, 2017
PR-URL: nodejs/node#16368
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
Backport-PR-URL: #16421
PR-URL: #16368
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
@MylesBorins MylesBorins mentioned this pull request Nov 21, 2017
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
Backport-PR-URL: #16421
PR-URL: #16368
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
Backport-PR-URL: #16421
PR-URL: #16368
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Dec 7, 2017
PR-URL: nodejs/node#16368
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations.

7 participants