Skip to content

test: fs.readFileSync -> fixtures.readKey#16030

Closed
EthanRBrown wants to merge 1 commit into
nodejs:masterfrom
EthanRBrown:master
Closed

test: fs.readFileSync -> fixtures.readKey#16030
EthanRBrown wants to merge 1 commit into
nodejs:masterfrom
EthanRBrown:master

Conversation

@EthanRBrown
Copy link
Copy Markdown
Contributor

@EthanRBrown EthanRBrown commented Oct 6, 2017 •
edited
Loading

  • [*] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [*] commit message follows commit guidelines
Affected core subsystem(s)

test
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 6, 2017
@mscdex mscdex added the https Issues or PRs related to the https subsystem. label Oct 6, 2017
@Trott Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 6, 2017
@addaleax
Copy link
Copy Markdown
Member

addaleax commented Oct 7, 2017

CI: https://ci.nodejs.org/job/node-test-commit/12851/
@Trott Trott closed this Oct 12, 2017
@Trott Trott reopened this Oct 12, 2017
@Trott
Copy link
Copy Markdown
Member

Trott commented Oct 12, 2017

Landed in bf8f1d3.
Thanks for the contribution! 🎉
@Trott Trott closed this Oct 12, 2017
Trott pushed a commit that referenced this pull request Oct 12, 2017
@EthanRBrown @Trott
test: fs.readFileSync -> fixtures.readKey
bf8f1d3 
PR-URL: #16030
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Oct 15, 2017
@EthanRBrown @addaleax
test: fs.readFileSync -> fixtures.readKey
acc2cb2 
PR-URL: nodejs/node#16030
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Oct 18, 2017
@EthanRBrown @targos
test: fs.readFileSync -> fixtures.readKey
08fa004 
PR-URL: #16030
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
@EthanRBrown @MylesBorins
test: fs.readFileSync -> fixtures.readKey
cc85bd0 
PR-URL: #16030
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Nov 21, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
@EthanRBrown @MylesBorins
test: fs.readFileSync -> fixtures.readKey
66b1d19 
PR-URL: #16030
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
@EthanRBrown @MylesBorins
test: fs.readFileSync -> fixtures.readKey
76ab029 
PR-URL: #16030
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. https Issues or PRs related to the https subsystem. test Issues and PRs related to the tests.