test: use common.fixtures module in test-https-agent-session-eviction#16012
Closed
chichiwang wants to merge 1 commit into
Closed
test: use common.fixtures module in test-https-agent-session-eviction#16012chichiwang wants to merge 1 commit into
chichiwang wants to merge 1 commit into
Conversation
Use common.fixtures module in test-https-agent-session-eviction
Trott
added
the
code-and-learn
addaleax
approved these changes
Oct 7, 2017
Member
tniessen
approved these changes
Oct 7, 2017
jasnell
approved these changes
Oct 9, 2017
Member
Member
|
CI will need to be re-run for this. It's not running any subtasks. |
Member
jasnell
pushed a commit
that referenced
this pull request
Oct 13, 2017
Use common.fixtures module in test-https-agent-session-eviction PR-URL: #16012 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
|
Landed in 8d3e82f |
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Oct 15, 2017
Use common.fixtures module in test-https-agent-session-eviction PR-URL: nodejs/node#16012 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Oct 18, 2017
Use common.fixtures module in test-https-agent-session-eviction PR-URL: #16012 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 16, 2017
Use common.fixtures module in test-https-agent-session-eviction PR-URL: #16012 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 21, 2017
Use common.fixtures module in test-https-agent-session-eviction PR-URL: #16012 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 28, 2017
Use common.fixtures module in test-https-agent-session-eviction PR-URL: #16012 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update test/parallel/test-https-agent-session-eviction.js to use common.fixtures module's readKey method.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes- [ ] tests and/or benchmarks are included- [ ] documentation is changed or addedAffected core subsystem(s)
None