Skip to content

Called fixturesDir directly from test-tls-client-getephemeralkeyinfo.js#15980

Closed
cougarkhan wants to merge 2 commits into
nodejs:masterfrom
cougarkhan:master
Closed

Called fixturesDir directly from test-tls-client-getephemeralkeyinfo.js#15980
cougarkhan wants to merge 2 commits into
nodejs:masterfrom
cougarkhan:master

Conversation

@cougarkhan
Copy link
Copy Markdown
Contributor

@cougarkhan cougarkhan commented Oct 6, 2017 •
edited by BridgeAR
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

test
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 6, 2017
@mscdex mscdex added the tls Issues and PRs related to the tls subsystem. label Oct 6, 2017
@Trott Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 6, 2017
BridgeAR
BridgeAR approved these changes Oct 7, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@refack refack self-assigned this Oct 10, 2017
lpinca
lpinca approved these changes Oct 13, 2017
View reviewed changes
Comment thread test/parallel/test-tls-client-getephemeralkeyinfo.js
@@ -1,20 +1,21 @@
'use strict';
const common = require('../common');
const fixtures = require('../common/fixtures');
Copy link
Copy Markdown
Member

@lpinca lpinca Oct 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: can you please move this after the common.hasCrypto check?
@jasnell
Copy link
Copy Markdown
Member

jasnell commented Oct 13, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/10688/
refack pushed a commit that referenced this pull request Oct 13, 2017
@cougarkhan @refack
test: added fixtures module
eac257f 
PR-URL: #15980
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@refack
Copy link
Copy Markdown
Contributor

refack commented Oct 13, 2017

Landed in eac257f

@cougarkhan congratulations 🍾
P.S. You might want to update you e-mail in github - https://github.com/settings/emails for the bragging rights
image
@refack refack closed this Oct 13, 2017
@joyeecheung joyeecheung mentioned this pull request Oct 14, 2017
Closed
4 tasks
addaleax pushed a commit to ayojs/ayo that referenced this pull request Oct 15, 2017
@cougarkhan @addaleax
test: added fixtures module
0f63c38 
PR-URL: nodejs/node#15980
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
targos pushed a commit that referenced this pull request Oct 18, 2017
@cougarkhan @targos
test: added fixtures module
734a2d3 
PR-URL: #15980
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
@cougarkhan @MylesBorins
test: added fixtures module
345d42b 
PR-URL: #15980
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Nov 21, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
@cougarkhan @MylesBorins
test: added fixtures module
86bdae3 
PR-URL: #15980
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
@cougarkhan @MylesBorins
test: added fixtures module
72f69f3 
PR-URL: #15980
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@refack refack removed their assignment Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests. tls Issues and PRs related to the tls subsystem.