Skip to content

test: replace common.fixturesDir w/ fixtures.path#15819

Closed
Druotic wants to merge 1 commit into
nodejs:masterfrom
Druotic:test-tls-connect-secure-context-common-fixtures
Closed

test: replace common.fixturesDir w/ fixtures.path#15819
Druotic wants to merge 1 commit into
nodejs:masterfrom
Druotic:test-tls-connect-secure-context-common-fixtures

Conversation

@Druotic
Copy link
Copy Markdown
Contributor

@Druotic Druotic commented Oct 6, 2017 •
edited
Loading

Description

In test/parallel/test-tls-connect-secure-context.js, replace common.fixturesDir with usage of the common.fixtures module.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

Simple test change for Node Interactive code and learn session.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 6, 2017
@mscdex mscdex added the tls Issues and PRs related to the tls subsystem. label Oct 6, 2017
@Trott Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 6, 2017
@lpinca
Copy link
Copy Markdown
Member

lpinca commented Oct 9, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/10526/
@lpinca
Copy link
Copy Markdown
Member

lpinca commented Oct 9, 2017 •
edited
Loading

There is a small typo in commit message: fixutres.path.
@Druotic Druotic force-pushed the test-tls-connect-secure-context-common-fixtures branch from 62e38e3 to 3f62305 Compare October 9, 2017 10:04
@Druotic Druotic changed the title test: replace common.fixturesDir w/ fixutres.path test: replace common.fixturesDir w/ fixtures.path Oct 9, 2017
@Druotic
Copy link
Copy Markdown
Contributor Author

Druotic commented Oct 9, 2017

Fixed the typo. @lpinca
@lpinca
Copy link
Copy Markdown
Member

lpinca commented Oct 10, 2017

Landed in 85a5a2c.
lpinca pushed a commit that referenced this pull request Oct 10, 2017
@Druotic @lpinca
test: replace common.fixturesDir w/ fixtures.path
85a5a2c 
PR-URL: #15819
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@lpinca lpinca closed this Oct 10, 2017
@Trott
Copy link
Copy Markdown
Member

Trott commented Oct 10, 2017

Thanks for the contribution! 🎉
MylesBorins pushed a commit that referenced this pull request Oct 11, 2017
@Druotic @MylesBorins
test: replace common.fixturesDir w/ fixtures.path
6f42b68 
PR-URL: #15819
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Oct 11, 2017
Merged
addaleax pushed a commit to addaleax/ayo that referenced this pull request Oct 12, 2017
@Druotic @addaleax
test: replace common.fixturesDir w/ fixtures.path
4f7bb10 
PR-URL: nodejs/node#15819
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 14, 2017
@Druotic @MylesBorins
test: replace common.fixturesDir w/ fixtures.path
ba7ba10 
PR-URL: #15819
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Nov 21, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
@Druotic @MylesBorins
test: replace common.fixturesDir w/ fixtures.path
24f620e 
PR-URL: #15819
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
@Druotic @MylesBorins
test: replace common.fixturesDir w/ fixtures.path
08ca73f 
PR-URL: #15819
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests. tls Issues and PRs related to the tls subsystem.