Skip to content

test: remove unused function args#14971

Closed
m13m wants to merge 1 commit into
nodejs:masterfrom
m13m:master
Closed

test: remove unused function args#14971
m13m wants to merge 1 commit into
nodejs:masterfrom
m13m:master

Conversation

@m13m
Copy link
Copy Markdown

@m13m m13m commented Aug 22, 2017

Removed unused arguments 'id' and 'type'.

Checklist

  • make-j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Affected core subsystem(s)
test
@nodejs-github-bot nodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. test Issues and PRs related to the tests. labels Aug 22, 2017
Trott
Trott approved these changes Aug 22, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@Trott
Copy link
Copy Markdown
Member

Trott commented Aug 22, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/9781/
jasnell pushed a commit that referenced this pull request Aug 24, 2017
@jasnell
test: remove unused function args
9fc58af 
PR-URL: #14971
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: David Cai <davidcai1993@yahoo.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Copy Markdown
Member

jasnell commented Aug 24, 2017

landed in 9fc58af
@jasnell jasnell closed this Aug 24, 2017
addaleax pushed a commit to addaleax/ayo that referenced this pull request Aug 25, 2017
@addaleax
test: remove unused function args
0401495 
PR-URL: nodejs/node#14971
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: David Cai <davidcai1993@yahoo.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Aug 28, 2017
@addaleax
test: remove unused function args
455d7a6 
PR-URL: nodejs/node#14971
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: David Cai <davidcai1993@yahoo.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Sep 10, 2017
@MylesBorins
test: remove unused function args
be2c711 
PR-URL: #14971
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: David Cai <davidcai1993@yahoo.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Sep 10, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Sep 12, 2017
@MylesBorins
test: remove unused function args
d4c2eba 
PR-URL: #14971
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: David Cai <davidcai1993@yahoo.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

async_hooks Issues and PRs related to the async hooks subsystem. test Issues and PRs related to the tests.

8 participants

@m13m @Trott @jasnell @danbev @hiroppy @DavidCai1111 @MylesBorins @nodejs-github-bot