Skip to content

[v8.x] test: improve the test common documentation#14454

Closed
addaleax wants to merge 1 commit into
nodejs:v8.x-stagingfrom
addaleax:backport-14148
Closed

[v8.x] test: improve the test common documentation#14454
addaleax wants to merge 1 commit into
nodejs:v8.x-stagingfrom
addaleax:backport-14148

Conversation

@addaleax
Copy link
Copy Markdown
Member

@addaleax addaleax commented Jul 24, 2017

Backport of #14148

/cc @refack @BridgeAR
@BridgeAR @addaleax
test: improve the test common documentation
770c7c7 
PR-URL: nodejs#14148
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. v8.x labels Jul 24, 2017
refack
refack suggested changes Jul 24, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@refack refack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes to expectsError were not ported yet
Comment thread test/common/README.md

### expectsError(settings)
* `settings` [&lt;Object>](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object)
### expectsError([fn, ]settings[, exact])
Copy link
Copy Markdown
Contributor

@refack refack Jul 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes were not ported (fn and exact)
@addaleax
Copy link
Copy Markdown
Member Author

addaleax commented Jul 24, 2017

@refack Thanks for the comment, I think this gave me a better idea than backporting this PR.
@addaleax addaleax closed this Jul 24, 2017
@refack
Copy link
Copy Markdown
Contributor

refack commented Jul 24, 2017

If possible I'd suggest trying

  1. test: add optional throw fn to expectsError #14089
  2. test: wrap expectsError in mustCall #14088
  3. errors, buffer: Migrate buffer errors to use internal/errors #13976
  4. test: Fix common.PIPE to be process unique #14168
  5. test: change isAix to isAIX #14263
  6. test: refactor expectsError #14058
  7. doc, lib, test: do not re-require needlessly #14244
  8. tools: eslint object curly spacing #14162

Or if it's easier with SHAs

  1. d6fece1
  2. 1b2733f
  3. dbfe8c4
  4. c34ae48
  5. fb37922
  6. 2a621d4
  7. 4f87522
  8. bb29405
@addaleax addaleax deleted the backport-14148 branch July 24, 2017 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test Issues and PRs related to the tests.

5 participants

@addaleax @refack @jasnell @nodejs-github-bot @BridgeAR