Skip to content

Fix linking from toc to subsection for 4.8.x releases#13039

Closed
frlan wants to merge 1 commit into
nodejs:masterfrom
frlan:master
Closed

Fix linking from toc to subsection for 4.8.x releases#13039
frlan wants to merge 1 commit into
nodejs:masterfrom
frlan:master

Conversation

@frlan
Copy link
Copy Markdown
Contributor

@frlan frlan commented May 15, 2017

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label May 15, 2017
@vsemozhetbyt
Copy link
Copy Markdown
Contributor

@frlan Thank you!

Dear reviewers, please, let me know if this can be landed without the common delay.

@gibfahn gibfahn self-assigned this May 18, 2017
@gibfahn
Copy link
Copy Markdown
Member

gibfahn commented May 18, 2017

@gibfahn
Copy link
Copy Markdown
Member

gibfahn commented May 18, 2017

Landed in 5de722a

Thanks for the PR @frlan !

@gibfahn gibfahn closed this May 18, 2017
gibfahn pushed a commit that referenced this pull request May 18, 2017
PR-URL: #13039
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
anchnk pushed a commit to anchnk/node that referenced this pull request May 19, 2017
PR-URL: nodejs#13039
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
@jasnell jasnell mentioned this pull request May 28, 2017
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations.

9 participants