Skip to content

doc: sort bottom-of-file markdown links#12726

Merged
sam-github merged 1 commit into
nodejs:masterfrom
sam-github:sort-markdown-links
May 8, 2017
Merged

doc: sort bottom-of-file markdown links#12726
sam-github merged 1 commit into
nodejs:masterfrom
sam-github:sort-markdown-links

Conversation

@sam-github
Copy link
Copy Markdown
Contributor

Checklist
Affected core subsystem(s)

doc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Apr 28, 2017
@sam-github
Copy link
Copy Markdown
Contributor Author

Copy link
Copy Markdown
Member

@lpinca lpinca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamp LGTM

@addaleax
Copy link
Copy Markdown
Member

addaleax commented May 7, 2017

@sam-github Can you rebase? :)

@sam-github sam-github force-pushed the sort-markdown-links branch from 4f942d7 to 5ba941f Compare May 8, 2017 16:30
PR-URL: nodejs#12726
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
@sam-github sam-github force-pushed the sort-markdown-links branch from 5ba941f to ea1b8a5 Compare May 8, 2017 16:31
@sam-github sam-github merged commit ea1b8a5 into nodejs:master May 8, 2017
@sam-github sam-github deleted the sort-markdown-links branch May 8, 2017 16:32
@addaleax addaleax mentioned this pull request May 8, 2017
4 tasks
anchnk pushed a commit to anchnk/node that referenced this pull request May 19, 2017
PR-URL: nodejs#12726
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
@jasnell jasnell mentioned this pull request May 11, 2017
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
3 tasks
@gibfahn
Copy link
Copy Markdown
Member

gibfahn commented Jun 20, 2017

Marking as don't land because it has a bajillion conflicts, feel free to backport if you want to though.

sam-github added a commit to sam-github/node that referenced this pull request Nov 28, 2018
Reapply nodejs#12726

It would be nice to have the sort check applied as part of doc testing,
but this change doesn't implement that.
Trott pushed a commit to Trott/io.js that referenced this pull request Nov 28, 2018
Reapply nodejs#12726

It would be nice to have the sort check applied as part of doc testing,
but this change doesn't implement that.

PR-URL: nodejs#24679
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2018
Reapply #12726

It would be nice to have the sort check applied as part of doc testing,
but this change doesn't implement that.

Backport-PR-URL: #24681
PR-URL: #24679
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 26, 2018
Reapply #12726

It would be nice to have the sort check applied as part of doc testing,
but this change doesn't implement that.

Backport-PR-URL: #24681
PR-URL: #24679
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
Reapply nodejs#12726

It would be nice to have the sort check applied as part of doc testing,
but this change doesn't implement that.

PR-URL: nodejs#24679
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations.

7 participants