zlib: remove unused declaration#12432
Closed
addaleax wants to merge 1 commit into
Closed
Conversation
Overlooked in nodejs#12366. Removing this removes a compiler warning.
addaleax
added
dont-land-on-v4.x
lib / src
nodejs-github-bot
added
c++
2 tasks
bnoordhuis
approved these changes
Apr 15, 2017
benjamingr
approved these changes
Apr 15, 2017
Member
Author
cjihrig
approved these changes
Apr 15, 2017
richardlau
approved these changes
Apr 15, 2017
gibfahn
approved these changes
Apr 16, 2017
Member
Author
|
Landed in ea01cd7 |
addaleax
added a commit
that referenced
this pull request
Apr 16, 2017
Overlooked in #12366. Removing this removes a compiler warning. PR-URL: #12432 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overlooked in #12366. Removing this
removes a compiler warning.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
src/zlib
Also trivial enough that I would say this doesn’t need to wait 48 hours.