Skip to content

node_symbols.cc uses deprecated V8 APIs #30916

@targos

Description

@targos

Warnings in canary:

[849/962] CXX obj/src/libnode.node_symbols.o
../../src/node_symbols.cc: In function ‘void node::symbols::Initialize(v8::Local<v8::Object>, v8::Local<v8::Value>, v8::Local<v8::Context>, void*)’:
../../src/node_symbols.cc:21:55: warning: ‘v8::Local<v8::Value> v8::Symbol::Name() const’ is deprecated: Use Symbol::Description() [-Wdeprecated-declarations]
   21 |       ->Set(env->context(), env->PropertyName()->Name(), env->PropertyName())  \
      |                                                       ^
../../src/env.h:164:3: note: in expansion of macro ‘V’
  164 |   V(handle_onclose_symbol, "handle_onclose")                                  \
      |   ^
../../src/node_symbols.cc:23:3: note: in expansion of macro ‘PER_ISOLATE_SYMBOL_PROPERTIES’
   23 |   PER_ISOLATE_SYMBOL_PROPERTIES(V)
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../../src/util.h:27,
                 from ../../src/aliased_buffer.h:7,
                 from ../../src/env-inl.h:27,
                 from ../../src/node_symbols.cc:1:
../../deps/v8/include/v8.h:3263:16: note: declared here
 3263 |   Local<Value> Name() const { return Description(); }
      |                ^~~~
../../src/node_symbols.cc:21:55: warning: ‘v8::Local<v8::Value> v8::Symbol::Name() const’ is deprecated: Use Symbol::Description() [-Wdeprecated-declarations]
   21 |       ->Set(env->context(), env->PropertyName()->Name(), env->PropertyName())  \
      |                                                       ^
../../src/env.h:165:3: note: in expansion of macro ‘V’
  165 |   V(no_message_symbol, "no_message_symbol")                                   \
      |   ^
../../src/node_symbols.cc:23:3: note: in expansion of macro ‘PER_ISOLATE_SYMBOL_PROPERTIES’
   23 |   PER_ISOLATE_SYMBOL_PROPERTIES(V)
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../../src/util.h:27,
                 from ../../src/aliased_buffer.h:7,
                 from ../../src/env-inl.h:27,
                 from ../../src/node_symbols.cc:1:
../../deps/v8/include/v8.h:3263:16: note: declared here
 3263 |   Local<Value> Name() const { return Description(); }
      |                ^~~~
../../src/node_symbols.cc:21:55: warning: ‘v8::Local<v8::Value> v8::Symbol::Name() const’ is deprecated: Use Symbol::Description() [-Wdeprecated-declarations]
   21 |       ->Set(env->context(), env->PropertyName()->Name(), env->PropertyName())  \
      |                                                       ^
../../src/env.h:166:3: note: in expansion of macro ‘V’
  166 |   V(oninit_symbol, "oninit")                                                  \
      |   ^
../../src/node_symbols.cc:23:3: note: in expansion of macro ‘PER_ISOLATE_SYMBOL_PROPERTIES’
   23 |   PER_ISOLATE_SYMBOL_PROPERTIES(V)
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../../src/util.h:27,
                 from ../../src/aliased_buffer.h:7,
                 from ../../src/env-inl.h:27,
                 from ../../src/node_symbols.cc:1:
../../deps/v8/include/v8.h:3263:16: note: declared here
 3263 |   Local<Value> Name() const { return Description(); }
      |                ^~~~
../../src/node_symbols.cc:21:55: warning: ‘v8::Local<v8::Value> v8::Symbol::Name() const’ is deprecated: Use Symbol::Description() [-Wdeprecated-declarations]
   21 |       ->Set(env->context(), env->PropertyName()->Name(), env->PropertyName())  \
      |                                                       ^
../../src/env.h:167:3: note: in expansion of macro ‘V’
  167 |   V(owner_symbol, "owner")                                                    \
      |   ^
../../src/node_symbols.cc:23:3: note: in expansion of macro ‘PER_ISOLATE_SYMBOL_PROPERTIES’
   23 |   PER_ISOLATE_SYMBOL_PROPERTIES(V)
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../../src/util.h:27,
                 from ../../src/aliased_buffer.h:7,
                 from ../../src/env-inl.h:27,
                 from ../../src/node_symbols.cc:1:
../../deps/v8/include/v8.h:3263:16: note: declared here
 3263 |   Local<Value> Name() const { return Description(); }
      |                ^~~~

Metadata

Metadata

Assignees

No one assigned

    Labels

    v8 engineIssues and PRs related to the V8 dependency.

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions