-
-
Notifications
You must be signed in to change notification settings - Fork 35.6k
Improve current workflow #25908
Copy link
Copy link
Closed
Labels
metaIssues and PRs related to the general management of the project.Issues and PRs related to the general management of the project.
Metadata
Metadata
Assignees
Labels
metaIssues and PRs related to the general management of the project.Issues and PRs related to the general management of the project.
Type
Fields
Give feedbackNo fields configured for issues without a type.
The core idea
Introduce Nodejs as base dependency to simplify current workflow.
The problem
When I work on src: refactor to nullptr #25888. I am pretty painful. With @joyeecheung awesome's work, we have
clang-formatalso withmake-formatc-cpp. But it's only available on unix-like os. And we have not clang-format the whole repo. I ended up copy the related snippet.Node community is more familiar with nodejs tools like npm or yarn instead of bash or bat file.
We may need to introduce more tools to improve develop efficiency like
prettierandhusky.How do we achieve this
package.jsonin project root and add nodejs inprerequesite.mdpacakge.json, remove the sources.huskyandlint-staged, and addclang-formatto the hooks. We can see it in electron and repo likeCRAsee https://github.com/facebook/create-react-app/blob/master/package.json and https://github.com/electron/electron/blob/master/package.json.Also we should agree on
.clang-formatrules and format thesrcandtestfolder commit to the repo.Update on 2019-02-07:
huskyandlint-stagedfor now, see Improve current workflow #25908 (comment)Update on 2019-02-12
eslintandbabel-eslintand all its dependency code to this repo. It's just a tool. Also with this review eslint upgrade will be much easier.Makefileandvcbuild.bat. Unify it inpackage.jsonwill remove redundant code.