Skip to content

Update CentOS6 support, add support for release nodes#740

Merged
rvagg merged 1 commit into
masterfrom
centos6-release
Jul 22, 2017
Merged

Update CentOS6 support, add support for release nodes#740
rvagg merged 1 commit into
masterfrom
centos6-release

Conversation

@rvagg
Copy link
Copy Markdown
Member

@rvagg rvagg commented May 29, 2017

ref #718

Also added these 2 release machines to ci-release and gave them a label post-8-release and added the following to the iojs+release scripting:

if [[ \
  $OSTYPE =~ linux && \
  $ARCH =~ x86_64|x64|i386|x86|ia32 && \
  ( \
    ( ${NODE_VERSION:0:1} -gt "7" && ! $NODE_LABELS =~ post-8-release ) || \
    ( ${NODE_VERSION:0:1} -lt "7" && $NODE_LABELS =~ post-8-release ) \
  ) \
]]; then
  echo "Not building Node.js ${NODE_VERSION:0:1} on $NODE_NAME"
  exit 0
fi
mhdawson

This comment was marked as off-topic.

@rvagg
Copy link
Copy Markdown
Member Author

rvagg commented May 29, 2017

sorry @mhdawson, didn't know we were onto a local ansible branch, can you point me to discussion or PR or something about that? I was still tracking jbergstroem/feature/refactor-the-world which is a bit out of date so I haven't used it.

@rvagg
Copy link
Copy Markdown
Member Author

rvagg commented May 29, 2017

oh, it's not a branch, it's a whole directory! ok .. will look into that

@mhdawson
Copy link
Copy Markdown
Member

mhdawson commented May 29, 2017

@rvagg its still a work in progress. We agreed at the vm summit in Berlin (with @jbergstroem via remote) to land the refactor and then move platform by platform over to it as we had time to validate.

gibfahn

This comment was marked as off-topic.

@rvagg
Copy link
Copy Markdown
Member Author

rvagg commented May 29, 2017

OK, that's great! I might ammend this PR to include the new work, that should give me a chance to have some proper hands-on experience with it.

@rvagg rvagg merged commit 3496872 into master Jul 22, 2017
@rvagg rvagg deleted the centos6-release branch July 22, 2017 05:00
piccoloaiutante pushed a commit to piccoloaiutante/build that referenced this pull request Aug 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants