Skip to content

Conversation

mytharcher
Copy link
Contributor

@mytharcher mytharcher commented Mar 25, 2025

This is a ...

  • New feature
  • Improvement
  • Bug fix
  • Others

Motivation

Adjust getFileData API.

Description

If you are using getFileData method for your customized storage (which extends from StorageType), you need to change the logic:

  class CustomizedStorage extends StorageType {
-   getFileData(file) {
-     return file;
-   }
+   getFileData(file, meta) {
+     return {
+       ...super.getFileData(file, meta),
+       // other fields, like `url`
+       url: file.url, // for Wecom uploaded files
+     };
+   }
  }

Related issues

Showcase

Changelog

Language Changelog
🇺🇸 English Adjust getFileData API of storage
🇨🇳 Chinese 调整存储引擎的 getFileData 方法 API

Docs

Language Link
🇺🇸 English
🇨🇳 Chinese

Checklists

  • All changes have been self-tested and work as expected
  • Test cases are updated/provided or not needed
  • Doc is updated/provided or not needed
  • Component demo is updated/provided or not needed
  • Changelog is provided or not needed
  • Request a code review if it is necessary

This comment has been minimized.

Copy link

Tests results for "E2E"

7 failed
❌ [chromium] › core/client/src/modules/blocks/data-blocks/table/e2e/schemaInitializer.test.ts:292:7 › configure actions column › view & edit & delete & duplicate & customize
❌ [chromium] › core/client/src/modules/page/e2e/router.test.ts:14:7 › router › page tabs
❌ [chromium] › core/client/src/modules/page/e2e/schemaSettings.test.ts:86:7 › tabs schema settings › edit
❌ [chromium] › core/client/src/modules/actions/e2e/action.schemaSetting.test.ts:14:7 › action settings › refresh data on action
❌ [chromium] › core/client/src/modules/blocks/data-blocks/form/e2e/form-create/schemaSettings2.test.ts:198:7 › linkage rules › variable labels should be displayed normally
❌ [chromium] › core/client/src/modules/blocks/data-blocks/table/e2e/actions/linkage.test.ts:14:5 › action linkage by row data
❌ [chromium] › core/client/src/modules/blocks/data-blocks/form/e2e/form-create/schemaSettings.test.ts:1048:9 › actions schema settings › customize: save record › supported options

31 flaky ⚠️ [chromium] › core/client/src/modules/page/__e2e__/schemaSettings.test.ts:102:7 › tabs schema settings › delete
⚠️ [chromium] › plugins/@nocobase/plugin-action-bulk-edit/src/client/__e2e__/popup.test.ts:14:7 › popup of bulk edit › the Add block button in drawer should be visible
⚠️ [chromium] › pro-plugins/@nocobase/plugin-workflow-approval/src/client/__e2e__/triggerNodeConfig/formConfig/relationField.test.ts:26:5 › Generic properties for o2m
⚠️ [chromium] › core/client/src/modules/blocks/data-blocks/details-multi/__e2e__/setDataLoadingModeSettingsItem.test.ts:14:7 › setDataLoadingModeSettingsItem › basic
⚠️ [chromium] › core/client/src/modules/blocks/data-blocks/table/__e2e__/pagination.test.ts:13:7 › pagination › basic
⚠️ [chromium] › core/client/src/modules/blocks/data-blocks/table/__e2e__/schemaSettings.test.ts:69:9 › actions schema settings › add new › edit button
⚠️ [chromium] › core/client/src/modules/blocks/data-blocks/table/__e2e__/schemaSettings.test.ts:81:9 › actions schema settings › add new › open mode
⚠️ [chromium] › core/client/src/modules/blocks/data-blocks/table/__e2e__/schemaSettings.test.ts:130:9 › actions schema settings › add new › popup size
⚠️ [chromium] › core/client/src/modules/blocks/data-blocks/table/__e2e__/schemaSettings.test.ts:159:9 › actions schema settings › add new › delete
⚠️ [chromium] › core/client/src/modules/blocks/data-blocks/table/__e2e__/schemaSettings.test.ts:233:9 › actions schema settings › delete › edit button
⚠️ [chromium] › core/client/src/modules/blocks/data-blocks/table/__e2e__/schemaSettings1.test.ts:65:9 › table block schema settings › enable drag and drop sorting › enable drag and drop sorting
⚠️ [chromium] › core/client/src/modules/blocks/data-blocks/table/__e2e__/schemaSettings1.test.ts:237:9 › table block schema settings › connect data blocks › connecting two blocks of the same collection
⚠️ [chromium] › core/client/src/modules/page/__e2e__/dragAndDrop.test.ts:12:5 › tabs
⚠️ [chromium] › core/client/src/schema-settings/__e2e__/linkageRules.test.ts:18:7 › linkage rules › form field depends on subtable fields with linkage rules
⚠️ [chromium] › plugins/@nocobase/plugin-acl/src/client/__e2e__/configure.test.ts:12:5 › allows to configure interface
⚠️ [chromium] › plugins/@nocobase/plugin-action-custom-request/src/client/__e2e__/customRequest.test.ts:14:7 › custom request action › supported variables in custom request buttons across different blocks
⚠️ [chromium] › pro-plugins/@nocobase/plugin-workflow-approval/src/client/__e2e__/triggerNodeConfig/processConfig/dataBlocks-InitiationAndApproval/noWithdrawalPermitted.test.ts:26:5 › approval passed
⚠️ [chromium] › core/client/src/modules/blocks/data-blocks/form/__e2e__/form-edit/schemaSettings.test.ts:56:7 › edit form block schema settings › Linkage rules
⚠️ [chromium] › core/client/src/modules/blocks/data-blocks/grid-card/__e2e__/schemaSettings.test.ts:14:7 › grid card block schema settings › supported options
⚠️ [chromium] › core/client/src/modules/blocks/data-blocks/grid-card/__e2e__/schemaSettings.test.ts:34:7 › grid card block schema settings › set the count of columns displayed in a row
⚠️ [chromium] › core/client/src/modules/blocks/data-blocks/grid-card/__e2e__/schemaSettings.test.ts:61:7 › grid card block schema settings › set the count of columns displayed in a row of new version
⚠️ [chromium] › core/client/src/modules/blocks/data-blocks/table/__e2e__/schemaSettings2.test.ts:13:7 › save as template › save as template, then delete it
⚠️ [chromium] › core/client/src/modules/variable/__e2e__/parentObject.test.ts:53:7 › variable: parent object › in linkage rules
⚠️ [chromium] › plugins/@nocobase/plugin-action-print/src/client/__e2e__/schemaInitailizer.test.ts:14:7 › ReadPrettyFormActionInitializers & CalendarFormActionInitializers should add print action › print action in ReadPrettyFormActionInitializers
⚠️ [chromium] › plugins/@nocobase/plugin-workflow-manual/src/client/__e2e__/updateRecordForm3.test.ts:191:7 › field data update › Collection event to add a data trigger, update integer data
⚠️ [chromium] › pro-plugins/@nocobase/plugin-workflow-custom-action-trigger/src/client/__e2e__/configuration.test.ts:275:7 › Workflow Enable Disable › Form event Workflow Add Data Trigger Disable Do Not Trigger
⚠️ [chromium] › core/client/src/modules/blocks/data-blocks/details-multi/__e2e__/schemaSettings.test.ts:20:7 › multi data details block schema settings › supported options
⚠️ [chromium] › core/client/src/schema-settings/__e2e__/actionAccessControl.test.ts:14:7 › Access control › popup、link、custom request support access control
⚠️ [chromium] › plugins/@nocobase/plugin-action-bulk-edit/src/client/__e2e__/schemaSettings.test.ts:14:7 › bulk edit action setting › data will be updated && edit form configure
⚠️ [chromium] › plugins/@nocobase/plugin-auth/src/client/__e2e__/auth.test.ts:21:7 › auth › register
⚠️ [chromium] › plugins/@nocobase/plugin-block-iframe/src/client/__e2e__/inPopup.test.ts:14:7 › iframe in popup › open popup, then close it, that should work

1169 passed, 37 skipped
✔️✔️✔️

Full HTML report. Merge workflow run.

@mytharcher mytharcher changed the base branch from main to next March 25, 2025 13:23
@mytharcher mytharcher merged commit bad6ac5 into next Mar 25, 2025
38 of 40 checks passed
@mytharcher mytharcher deleted the refactor/plugin-file-manager-get-file-data branch March 25, 2025 13:35
mytharcher added a commit that referenced this pull request May 14, 2025
* refactor(plugin-file-manager): adjust getFileData API

* fix(plugin-file-manager): fix cache and test case

* fix(plugin-file-manager): fix test case
mytharcher added a commit that referenced this pull request May 14, 2025
…permission (#6863)

* fix(plugin-file-manager): fix create file record without foreignkey permission

* refactor(plugin-file-manager): adjust getFileData API (#6553)

* refactor(plugin-file-manager): adjust getFileData API

* fix(plugin-file-manager): fix cache and test case

* fix(plugin-file-manager): fix test case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant