Skip to content

Conversation

gchust
Copy link
Contributor

@gchust gchust commented Mar 24, 2025

This is a ...

  • New feature
  • Improvement
  • Bug fix
  • Others

Motivation

Description

Related issues

Showcase

Changelog

Language Changelog
🇺🇸 English Save as template action will be failed if containing association field
🇨🇳 Chinese 存在关联字段的区块另存为模板报错

Docs

Language Link
🇺🇸 English
🇨🇳 Chinese

Checklists

  • All changes have been self-tested and work as expected
  • Test cases are updated/provided or not needed
  • Doc is updated/provided or not needed
  • Component demo is updated/provided or not needed
  • Changelog is provided or not needed
  • Request a code review if it is necessary

This comment has been minimized.

Copy link

Tests results for "E2E"

2 fatal errors, not part of any test
26 failed
❌ [chromium] › core/client/src/modules/blocks/data-blocks/form/e2e/form-create/schemaSettings2.test.ts:19:7 › linkage rules › basic usage
❌ [chromium] › core/client/src/modules/blocks/data-blocks/grid-card/e2e/schemaSettings.test.ts:35:7 › grid card block schema settings › set the count of columns displayed in a row
❌ [chromium] › core/client/src/modules/blocks/data-blocks/table/e2e/actions/linkage.test.ts:14:5 › action linkage by row data
❌ [chromium] › core/client/src/modules/fields/component/Select/e2e/selectOptionsInLinkageRule.test.ts:14:7 › options of Select field in linkage rule › options change with linkage rule
❌ [chromium] › core/client/src/modules/variable/e2e/parentObject.test.ts:53:7 › variable: parent object › in linkage rules
❌ [chromium] › core/client/src/modules/blocks/data-blocks/list/e2e/schemaInitializer.test.ts:30:7 › where list block can be added › popup
❌ [chromium] › core/client/src/modules/blocks/data-blocks/table/e2e/schemaInitializer.test.ts:292:7 › configure actions column › view & edit & delete & duplicate & customize
❌ [chromium] › core/client/src/modules/blocks/data-blocks/table/e2e/schemaInitializer1.test.ts:30:7 › where table block can be added › popup
❌ [chromium] › core/client/src/modules/blocks/filter-blocks/e2e/schemaInitializer.test.ts:14:7 › where filter block can be added › page
❌ [chromium] › plugins/@nocobase/plugin-data-visualization/src/client/e2e/defaultValue.test.ts:13:7 › defaultValue › date variables
❌ [chromium] › core/client/src/modules/blocks/data-blocks/form/e2e/form-edit/schemaSettings.test.ts:193:7 › actions schema settings › customize: save record
❌ [chromium] › core/client/src/modules/page/e2e/router.test.ts:14:7 › router › page tabs
❌ [chromium] › pro-plugins/@nocobase/plugin-workflow-approval/src/client/e2e/passthroughMode/formConfig/field.test.ts:31:5 › Details block
❌ [chromium] › pro-plugins/@nocobase/plugin-workflow-approval/src/client/e2e/passthroughMode/processConfig/approver.test.ts:464:7 › orMode › Select assignees, Variable 3 persons, passed.
❌ [chromium] › pro-plugins/@nocobase/plugin-workflow-approval/src/client/e2e/passthroughMode/processConfig/approver.test.ts:705:7 › orMode › Query assignees, 3 persons, passed.
❌ [chromium] › pro-plugins/@nocobase/plugin-workflow-approval/src/client/e2e/passthroughMode/processConfig/approver.test.ts:948:7 › orMode › Select assignees, Fixed 1 person; Query assignees, 2 persons,passed.
❌ [chromium] › pro-plugins/@nocobase/plugin-workflow-approval/src/client/e2e/passthroughMode/processConfig/orMode.test.ts:469:5 › 3 in parallel, first one, approval returned
❌ [chromium] › pro-plugins/@nocobase/plugin-workflow-approval/src/client/e2e/branchMode/formConfig/block.test.ts:1362:5 › Pre-Manual block, create record form
❌ [chromium] › pro-plugins/@nocobase/plugin-workflow-approval/src/client/e2e/branchMode/processConfig/approver.test.ts:430:7 › orMode › Select assignees, Variable 3 persons, passed.
❌ [chromium] › pro-plugins/@nocobase/plugin-workflow-approval/src/client/e2e/branchMode/processConfig/approver.test.ts:652:7 › orMode › Query assignees, 3 persons, passed.
❌ [chromium] › pro-plugins/@nocobase/plugin-workflow-approval/src/client/e2e/branchMode/processConfig/approver.test.ts:876:7 › orMode › Select assignees, Fixed 1 person; Query assignees, 2 persons,passed.
❌ [chromium] › core/client/src/modules/blocks/other-blocks/markdown/e2e/schemaSettings.test.ts:26:7 › markdown block schema settings › edit markdown
❌ [chromium] › plugins/@nocobase/plugin-action-custom-request/src/client/e2e/schemaSettings.test.ts:13:7 › custom request action › edit button
❌ [chromium] › pro-plugins/@nocobase/plugin-workflow-approval/src/client/e2e/passthroughMode/processConfig/andMode.test.ts:523:5 › 3 in parallel, first one, approval returned
❌ [chromium] › plugins/@nocobase/plugin-workflow-manual/src/client/e2e/datablocks.test.ts:154:7 › field data › Collection event to add a data trigger, get aggregate node data
❌ [chromium] › pro-plugins/@nocobase/plugin-workflow-approval/src/client/e2e/passthroughMode/processConfig/votingMode.test.ts:272:5 › 3 in parallel, 2 reject

86 flaky ⚠️ [chromium] › plugins/@nocobase/plugin-workflow-manual/src/client/__e2e__/updateRecordForm3.test.ts:28:7 › field data update › Collection event to add a data trigger, update Email Data
⚠️ [chromium] › plugins/@nocobase/plugin-workflow-manual/src/client/__e2e__/updateRecordForm3.test.ts:191:7 › field data update › Collection event to add a data trigger, update integer data
⚠️ [chromium] › plugins/@nocobase/plugin-workflow-manual/src/client/__e2e__/updateRecordForm3.test.ts:354:7 › field data update › Collection event to add a data trigger, update number data
⚠️ [chromium] › core/client/src/modules/variable/__e2e__/currentRecord.test.ts:14:7 › variable: Current Record › Current record should be consistent with current form field values
⚠️ [chromium] › plugins/@nocobase/plugin-gantt/src/client/__e2e__/schemaSettings.test.ts:26:7 › configure params in gantt block › set data scope in gantt block
⚠️ [chromium] › plugins/@nocobase/plugin-gantt/src/client/__e2e__/schemaSettings.test.ts:75:7 › configure params in gantt block › set end date field
⚠️ [chromium] › plugins/@nocobase/plugin-gantt/src/client/__e2e__/schemaSettings.test.ts:90:7 › configure params in gantt block › set time scale
⚠️ [chromium] › core/client/src/modules/blocks/data-blocks/table/__e2e__/popups.test.ts:35:7 › popup opened by clicking the association field › popup configuration should persist across different rows in the same column
⚠️ [chromium] › core/client/src/modules/blocks/data-blocks/table/__e2e__/schemaSettings1.test.ts:317:9 › table block schema settings › connect data blocks › should immediately show in the drop-down menu of Connect data blocks when adding a block for the first time
⚠️ [chromium] › core/client/src/modules/blocks/data-blocks/table/__e2e__/schemaSettings1.test.ts:360:9 › table block schema settings › connect data blocks › should not lose the filtering function when dragging and connecting
⚠️ [chromium] › core/client/src/modules/blocks/filter-blocks/__e2e__/schemaInitializer.test.ts:98:7 › where filter block can be added › popup
⚠️ [chromium] › plugins/@nocobase/plugin-acl/src/client/__e2e__/collection1.test.ts:73:7 › view › individual collection permission with fields
⚠️ [chromium] › plugins/@nocobase/plugin-acl/src/client/__e2e__/configure.test.ts:12:5 › allows to configure interface
⚠️ [chromium] › plugins/@nocobase/plugin-acl/src/client/__e2e__/configure.test.ts:133:5 › plugin settings permissions
⚠️ [chromium] › plugins/@nocobase/plugin-action-bulk-update/src/client/__e2e__/schemaInitailizer.test.ts:14:7 › TableActionInitializers & GanttActionInitializers & MapActionInitializers › TableActionInitializers should add bulk update
⚠️ [chromium] › plugins/@nocobase/plugin-data-source-main/src/client/__e2e__/fields/createdAt/schemaInitializer.test.ts:66:7 › form item & filter form › should be editable
⚠️ [chromium] › plugins/@nocobase/plugin-data-source-main/src/client/__e2e__/fields/createdAt/schemaInitializer.test.ts:117:7 › table column & table › configure columns
⚠️ [chromium] › core/client/src/modules/blocks/data-blocks/details-multi/__e2e__/schemaInitializer.test.ts:62:7 › configure fields › display collection fields & display association fields & add text
⚠️ [chromium] › core/client/src/modules/blocks/data-blocks/details-multi/__e2e__/schemaSettings.test.ts:20:7 › multi data details block schema settings › supported options
⚠️ [chromium] › core/client/src/modules/blocks/data-blocks/grid-card/__e2e__/schemaInitializer.test.ts:31:7 › where grid card block can be added › popup
⚠️ [chromium] › core/client/src/modules/blocks/data-blocks/table/__e2e__/schemaSettings.test.ts:59:9 › actions schema settings › add new › supported options
⚠️ [chromium] › core/client/src/modules/blocks/data-blocks/table/__e2e__/schemaSettings.test.ts:130:9 › actions schema settings › add new › popup size
⚠️ [chromium] › core/client/src/modules/blocks/data-blocks/table/__e2e__/schemaSettings.test.ts:288:9 › actions schema settings › view › supported options
⚠️ [chromium] › core/client/src/modules/blocks/data-blocks/table-selector/__e2e__/schemaInitializer.test.ts:35:7 › configure actions › filter & add new & delete & refresh
⚠️ [chromium] › core/client/src/modules/fields/__e2e__/component/AssociationSelect/dataScope.test.ts:46:7 › AssociationSelect › using multi-level association field values in data scope
⚠️ [chromium] › core/client/src/modules/page/__e2e__/dragAndDrop.test.ts:12:5 › tabs
⚠️ [chromium] › core/client/src/schema-settings/__e2e__/linkageRules.test.ts:18:7 › linkage rules › form field depends on subtable fields with linkage rules
⚠️ [chromium] › plugins/@nocobase/plugin-action-bulk-edit/src/client/__e2e__/popup.test.ts:14:7 › popup of bulk edit › the Add block button in drawer should be visible
⚠️ [chromium] › pro-plugins/@nocobase/plugin-workflow-approval/src/client/__e2e__/branchMode/formConfig/field.test.ts:32:5 › Details block
⚠️ [chromium] › pro-plugins/@nocobase/plugin-workflow-approval/src/client/__e2e__/branchMode/formConfig/field.test.ts:485:5 › Pre-CreateRecord block
⚠️ [chromium] › pro-plugins/@nocobase/plugin-workflow-approval/src/client/__e2e__/branchMode/formConfig/field.test.ts:735:5 › Pre-Manual block, create record form
⚠️ [chromium] › pro-plugins/@nocobase/plugin-workflow-approval/src/client/__e2e__/passthroughMode/formConfig/block.test.ts:211:5 › Delete details block
⚠️ [chromium] › pro-plugins/@nocobase/plugin-workflow-approval/src/client/__e2e__/passthroughMode/formConfig/block.test.ts:930:5 › Pre-Aggregate block
⚠️ [chromium] › pro-plugins/@nocobase/plugin-workflow-approval/src/client/__e2e__/passthroughMode/formConfig/field.test.ts:583:5 › Pre-Manual block, create record form
⚠️ [chromium] › pro-plugins/@nocobase/plugin-workflow-approval/src/client/__e2e__/passthroughMode/processConfig/approver.test.ts:246:7 › orMode › Select assignees, Fixed 2 person, passed.
⚠️ [chromium] › pro-plugins/@nocobase/plugin-workflow-approval/src/client/__e2e__/passthroughMode/processConfig/orMode.test.ts:29:5 › 3 in parallel, first one, approval passed
⚠️ [chromium] › pro-plugins/@nocobase/plugin-workflow-approval/src/client/__e2e__/passthroughMode/processConfig/orMode.test.ts:249:5 › 3 in parallel, first one, approval reject
⚠️ [chromium] › pro-plugins/@nocobase/plugin-workflow-approval/src/client/__e2e__/passthroughMode/processConfig/orMode.test.ts:689:5 › Serial of 3, first one, approval passed
⚠️ [chromium] › pro-plugins/@nocobase/plugin-workflow-approval/src/client/__e2e__/passthroughMode/processConfig/orMode.test.ts:905:5 › Serial of 3, first one, approval reject
⚠️ [chromium] › pro-plugins/@nocobase/plugin-workflow-approval/src/client/__e2e__/passthroughMode/processConfig/orMode.test.ts:1121:5 › Serial of 3, first one, approval returned
⚠️ [chromium] › pro-plugins/@nocobase/plugin-workflow-approval/src/client/__e2e__/branchMode/formConfig/block.test.ts:1140:5 › Pre-Aggregate block
⚠️ [chromium] › pro-plugins/@nocobase/plugin-workflow-approval/src/client/__e2e__/branchMode/formConfig/relationField.test.ts:252:5 › Details block, o2m relational field, The field component sets record picker
⚠️ [chromium] › pro-plugins/@nocobase/plugin-workflow-approval/src/client/__e2e__/branchMode/processConfig/approver.test.ts:229:7 › orMode › Select assignees, Fixed 2 person, passed.
⚠️ [chromium] › pro-plugins/@nocobase/plugin-workflow-approval/src/client/__e2e__/branchMode/processConfig/votingMode.test.ts:30:5 › 3 in parallel, 2 passed
⚠️ [chromium] › pro-plugins/@nocobase/plugin-workflow-approval/src/client/__e2e__/branchMode/processConfig/votingMode.test.ts:313:5 › 3 in parallel, Rejection is the end, 2 reject
⚠️ [chromium] › pro-plugins/@nocobase/plugin-workflow-approval/src/client/__e2e__/branchMode/processConfig/votingMode.test.ts:597:5 › 3 in parallel, 2 reject
⚠️ [chromium] › pro-plugins/@nocobase/plugin-workflow-approval/src/client/__e2e__/branchMode/processConfig/votingMode.test.ts:880:5 › 3 in parallel, first one, approval returned
⚠️ [chromium] › pro-plugins/@nocobase/plugin-workflow-approval/src/client/__e2e__/branchMode/processConfig/votingMode.test.ts:1143:5 › Serial of 3, 2 passed
⚠️ [chromium] › pro-plugins/@nocobase/plugin-workflow-approval/src/client/__e2e__/branchMode/processConfig/votingMode.test.ts:1418:5 › Serial of 3, Rejection is the end, 2 reject
⚠️ [chromium] › pro-plugins/@nocobase/plugin-workflow-approval/src/client/__e2e__/branchMode/processConfig/votingMode.test.ts:1691:5 › Serial of 3, 2 reject
⚠️ [chromium] › pro-plugins/@nocobase/plugin-workflow-approval/src/client/__e2e__/branchMode/processConfig/votingMode.test.ts:1963:5 › Serial of 3, first one, approval returned
⚠️ [chromium] › pro-plugins/@nocobase/plugin-workflow-approval/src/client/__e2e__/triggerNodeConfig/processConfig/approvalCentreInitiated-DataBlockApproval/withdrawalPermitted.test.ts:178:5 › approval returned
⚠️ [chromium] › plugins/@nocobase/plugin-workflow/src/client/__e2e__/updateRecordNode/updateInABatch1.test.ts:185:5 › Collection event add data trigger, filter single line text field not empty, common table single line text field data, set trigger node single line text field variable
⚠️ [chromium] › plugins/@nocobase/plugin-workflow/src/client/__e2e__/updateRecordNode/updateOneByOne1.test.ts:186:5 › Collection event add data trigger, filter single line text field not empty, common table single line text field data, set trigger node single line text field variable
⚠️ [chromium] › plugins/@nocobase/plugin-workflow-manual/src/client/__e2e__/customFormBlocks1.test.ts:26:7 › field data entry › Collection event to add a data trigger, entering multiple select data
⚠️ [chromium] › plugins/@nocobase/plugin-workflow-manual/src/client/__e2e__/customFormBlocks1.test.ts:324:7 › field data entry › Collection event to add a data trigger, entering checkbox group data
⚠️ [chromium] › plugins/@nocobase/plugin-workflow-manual/src/client/__e2e__/customFormBlocks1.test.ts:475:7 › field data entry › Collection event to add a data trigger, entering datetime data
⚠️ [chromium] › plugins/@nocobase/plugin-data-source-main/src/client/__e2e__/fields/attachment/schemaInitializer.test.ts:80:7 › table column & table › configure columns
⚠️ [chromium] › plugins/@nocobase/plugin-data-source-main/src/client/__e2e__/fields/singleLineText/schemaInitializer.test.ts:13:7 › form item & filter form › supported options
⚠️ [chromium] › core/client/src/modules/blocks/data-blocks/form/__e2e__/form-create/schemaSettings.test.ts:1048:9 › actions schema settings › customize: save record › supported options
⚠️ [chromium] › core/client/src/modules/popup/__e2e__/schemaInitializer.test.ts:40:7 › add blocks to the popup › no inheritance, no views, with association fields
⚠️ [chromium] › core/client/src/modules/popup/__e2e__/schemaInitializer.test.ts:66:7 › add blocks to the popup › with inheritance, with association fields
⚠️ [chromium] › core/client/src/modules/popup/__e2e__/schemaInitializer.test.ts:129:7 › add blocks to the popup › only support association fields
⚠️ [chromium] › plugins/@nocobase/plugin-auth/src/client/__e2e__/auth.test.ts:21:7 › auth › register
⚠️ [chromium] › plugins/@nocobase/plugin-calendar/src/client/__e2e__/schemaInitializer.test.ts:14:7 › where can be added › page
⚠️ [chromium] › plugins/@nocobase/plugin-calendar/src/client/__e2e__/schemaInitializer.test.ts:28:7 › where can be added › association block in popup
⚠️ [chromium] › plugins/@nocobase/plugin-gantt/src/client/__e2e__/schemaInitailizer.test.ts:13:5 › BlockInitializers should add gantt block
⚠️ [chromium] › plugins/@nocobase/plugin-mobile/src/client/__e2e__/zIndex.test.ts:86:7 › zIndex › modal of Assign field values and modal of Bind workflows
⚠️ [chromium] › pro-plugins/@nocobase/plugin-workflow-approval/src/client/__e2e__/passthroughMode/processConfig/andMode.test.ts:29:5 › 3 in parallel, 3 passed
⚠️ [chromium] › pro-plugins/@nocobase/plugin-workflow-approval/src/client/__e2e__/passthroughMode/processConfig/andMode.test.ts:303:5 › 3 in parallel, first one, approval reject
⚠️ [chromium] › pro-plugins/@nocobase/plugin-workflow-approval/src/client/__e2e__/passthroughMode/processConfig/andMode.test.ts:743:5 › Serial of 3, 3 passed
⚠️ [chromium] › pro-plugins/@nocobase/plugin-workflow-approval/src/client/__e2e__/passthroughMode/processConfig/andMode.test.ts:996:5 › Serial of 3, first one, approval reject
⚠️ [chromium] › pro-plugins/@nocobase/plugin-workflow-approval/src/client/__e2e__/triggerNodeConfig/formConfig/field.test.ts:25:5 › Generic properties for single-line text
⚠️ [chromium] › plugins/@nocobase/plugin-workflow/src/client/__e2e__/ScheduleEventTrigger/workflowCRUD.test.ts:46:7 › Add new › add new Schedule event
⚠️ [chromium] › plugins/@nocobase/plugin-workflow/src/client/__e2e__/updateRecordNode/updateInABatch.test.ts:180:5 › Collection event add data trigger, filter dropdown radio fields not empty, common table dropdown radio fields data, set trigger node dropdown radio fields variable
⚠️ [chromium] › plugins/@nocobase/plugin-workflow-manual/src/client/__e2e__/datablocks1.test.ts:355:7 › field data › Collection event to add a data trigger, get single line text data for manual node update record form
⚠️ [chromium] › plugins/@nocobase/plugin-workflow-manual/src/client/__e2e__/datablocks2.test.ts:123:7 › field data › Collection event to add a data trigger, get calculation node data
⚠️ [chromium] › plugins/@nocobase/plugin-workflow-manual/src/client/__e2e__/datablocks2.test.ts:231:7 › field data › Collection event to add a data trigger, get query record node data
⚠️ [chromium] › plugins/@nocobase/plugin-workflow-manual/src/client/__e2e__/updateRecordForm.test.ts:36:7 › field data update › Collection event to add a data trigger, update percentage data
⚠️ [chromium] › plugins/@nocobase/plugin-workflow-manual/src/client/__e2e__/updateRecordForm2.test.ts:354:7 › field data update › Collection event to add a data trigger, update mobile phone number data
⚠️ [chromium] › plugins/@nocobase/plugin-data-source-main/src/client/__e2e__/fields/markdown/schemaSettings.test.ts:76:7 › form item & create form › pattern
⚠️ [chromium] › pro-plugins/@nocobase/plugin-workflow-approval/src/client/__e2e__/branchMode/processConfig/orMode.test.ts:1082:5 › Serial of 3, first one, approval passed
⚠️ [chromium] › pro-plugins/@nocobase/plugin-workflow-approval/src/client/__e2e__/passthroughMode/processConfig/votingMode.test.ts:29:5 › 3 in parallel, 2 passed
⚠️ [chromium] › pro-plugins/@nocobase/plugin-workflow-approval/src/client/__e2e__/passthroughMode/processConfig/votingMode.test.ts:514:5 › 3 in parallel, first one, approval returned
⚠️ [chromium] › pro-plugins/@nocobase/plugin-workflow-approval/src/client/__e2e__/passthroughMode/processConfig/votingMode.test.ts:1202:5 › Serial of 3, first one, approval returned
⚠️ [chromium] › pro-plugins/@nocobase/plugin-workflow-approval/src/client/__e2e__/triggerNodeConfig/formConfig/button.test.ts:24:5 › Secondary confirmation

1079 passed, 48 skipped, 7 did not run
✔️✔️✔️

Full HTML report. Merge workflow run.

@gchust gchust merged commit aa51c69 into develop Mar 25, 2025
6 of 11 checks passed
@gchust gchust deleted the fix-save-as-for-old-template branch March 25, 2025 05:04
gchust added a commit that referenced this pull request Mar 25, 2025
#6543)

* fix: save as template not working if fields containing nest properties

* fix: hide old blocks save as template

* fix: unit tests failing

* fix: unit tests for hiding old save template option

* fix: unit test failing for save as template
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant