Skip to content

Add support for CMake submodule#9

Merged
nlohmann merged 2 commits into
nlohmann:masterfrom
h3x4n1um:cmake-submodule
Nov 11, 2020
Merged

Add support for CMake submodule#9
nlohmann merged 2 commits into
nlohmann:masterfrom
h3x4n1um:cmake-submodule

Conversation

@h3x4n1um

@h3x4n1um h3x4n1um commented Nov 10, 2020

Copy link
Copy Markdown
Contributor

Allow using fifo_map as a submodule in CMake

Example:

# use fifo_map submodule
add_subdirectory(third_party/fifo_map)

# link fifo_map submodule
target_link_libraries(foo PRIVATE fifo_map::fifo_map)
@coveralls

coveralls commented Nov 10, 2020 •
edited
Loading

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling fd37ab5 on h3x4n1um:cmake-submodule into a5a5b4d on nlohmann:master.
nlohmann
nlohmann requested changes Nov 10, 2020
View reviewed changes
Comment thread CMakeLists.txt Outdated
@h3x4n1um @nlohmann
Add end line in CMakeLists.txt
fd37ab5 
Co-authored-by: Niels Lohmann <niels.lohmann@gmail.com>
@h3x4n1um h3x4n1um requested a review from nlohmann November 11, 2020 03:03
nlohmann
nlohmann approved these changes Nov 11, 2020
View reviewed changes

@nlohmann nlohmann left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
@nlohmann nlohmann merged commit fbcbb52 into nlohmann:master Nov 11, 2020
@nlohmann

nlohmann commented Nov 11, 2020

Copy link
Copy Markdown
Owner

Thanks!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@h3x4n1um @coveralls @nlohmann