[ENH]: Add CAT12 SANLM denoising filter - #3374
Merged
Merged
Conversation
effigies
reviewed
Sep 29, 2021
Contributor
Author
|
Thank you for the review @effigies and sorry for the delay, I had a lot to work in the past days. I'm going to work again on the PR next week! BW |
default suffix removed Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
example filename Co-authored-by: Chris Markiewicz <effigies@gmail.com>
use fname_presuffix for output file Co-authored-by: Chris Markiewicz <effigies@gmail.com>
0rC0
changed the title
effigies
reviewed
Oct 13, 2021
effigies
left a comment
effigies
left a comment
Member
There was a problem hiding this comment.
This is what I was thinking for spm_type:
Member
|
Can you merge/rebase |
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
effigies
reviewed
Oct 18, 2021
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Contributor
Author
|
Super! :-) and thanks for the help @effigies |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2783.
List of changes proposed in this PR (pull-request)
Acknowledgment