MAINT: Simplify interface execution and better error handling of Node - #3349
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3349 +/- ##
==========================================
+ Coverage 64.23% 65.13% +0.89%
==========================================
Files 307 307
Lines 40373 40364 -9
Branches 5326 5333 +7
==========================================
+ Hits 25935 26290 +355
+ Misses 13385 13005 -380
- Partials 1053 1069 +16
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
@oesteban Rebase to clean up the diff? |
104c3cc to
5210a3b
Compare
|
@oesteban Rebased on your behalf. |
effigies
left a comment
There was a problem hiding this comment.
Overall I think it looks good. A couple initial thoughts, and please bug me to do another review.
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
c0f49c7 to
bbcd4ff
Compare
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
effigies
left a comment
There was a problem hiding this comment.
LGTM. Suggested updating the linear to have the same exception behavior as distributed, but don't feel very strongly.
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
|
Failing test fixed in #3378. Merging. |
Revises the implementation of
Nodesimplifying some details and improves the error handling of plugins. Introduces aNodeExecutionError(custom alias ofRuntimeError) that allows more specificity with errors, if needed.Requires: #3347.
Summary
Fixes # .
List of changes proposed in this PR (pull-request)
Acknowledgment