[FIX] #2435 Error creating gradients in DTIRecon

[mmromero]

The bvecs file was read assuming that directions followed YZX order, which created a gradients_matrix.txt with swapped directions. The new order is XYZ.

Closes #2435.

[effigies]

Thanks for this. If it's not too much trouble, I have a suggestion for additional cleanup.

[effigies]

Let's just go ahead and simplify this while we're here:

with open(bvecs_file) as fbvecs:
    bvecs_x = fbvecs.readline().split()
    bvecs_y = fbvecs.readline().split()
    bvecs_z = fbvecs.readline().split()

[effigies]

Great, thanks. Can you verify that this still produces the output you need?

[mmromero]

I did verify it before committing.

[codecov-io]

Codecov Report

Merging #2460 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master    #2460   +/-   ##
=======================================
  Coverage   66.62%   66.62%           
=======================================
  Files         328      328           
  Lines       42508    42508           
  Branches     5280     5277    -3     
=======================================
  Hits        28321    28321           
  Misses      13505    13505           
  Partials      682      682

Flag	Coverage Δ
#smoketests	50.73% <ø> (ø)	⬆️
#unittests	63.95% <0%> (ø)	⬆️

Impacted Files	Coverage Δ
nipype/interfaces/diffusion_toolkit/dti.py	63.88% <0%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc750f4...0262588. Read the comment docs.

[effigies]

I'll merge this in a batch with some others soon. Do you want to add yourself to the .zenodo.json? You'll be listed as a contributor in the Zenodo entry for the next release.

[effigies]

Merging. Please update Zenodo in another PR, if you would like to be listed as a contributor.