Ensure C++ compatibility in examples#552
Open
rats159 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes sure all the examples and examples renderers are as C++ compatible as possible, without changing any semantics. It mostly involves reordering initializers because the C++ standard requires that inside a designated initializer, all fields are initialized in the exact order they're declared, but also adds a few casts, and removes chained initializers like
.layout.sizing.width.minMax = ..., because those are nonstandard in C++. It also removes a few non-braced initializers like.sizing = CLAY_SIZING_GROW(), and adds a few float literals where the language warns about implicit conversions.There may still be a few cases of invalid C++ code, either because the example uses a C feature that C++ doesn't have (like compound literals
(int[]) {1,2,3}), or because the errors/warnings were hidden by type errors from libraries I didn't have installed.