Skip to content

pageserver: add gRPC compression #12280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 19, 2025
Merged

pageserver: add gRPC compression #12280

merged 2 commits into from
Jun 19, 2025

Conversation

erikgrinaker
Copy link
Contributor

@erikgrinaker erikgrinaker commented Jun 18, 2025

Problem

The gRPC page service should support compression.

Requires #12111.
Touches #11728.
Touches https://github.com/neondatabase/cloud/issues/25679.

Summary of changes

Add support for gzip and zstd compression in the server, and a client parameter to enable compression.

This will need further benchmarking under realistic network conditions.

@erikgrinaker erikgrinaker requested a review from a team as a code owner June 18, 2025 05:29
Copy link

github-actions bot commented Jun 18, 2025

8492 tests run: 7910 passed, 0 failed, 582 skipped (full report)


Code coverage* (full report)

  • functions: 32.0% (9036 of 28199 functions)
  • lines: 48.3% (80316 of 166178 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
a426efc at 2025-06-18T17:58:38.616Z :recycle:
Base automatically changed from elizabeth/domain-type-client to main June 18, 2025 15:59
@erikgrinaker erikgrinaker force-pushed the erik/grpc-compression branch from 26bdc1f to a426efc Compare June 18, 2025 16:59
@erikgrinaker erikgrinaker enabled auto-merge June 18, 2025 17:00
@erikgrinaker
Copy link
Contributor Author

@VladLazar I'll need a storage ✅ on this.

@erikgrinaker erikgrinaker added this pull request to the merge queue Jun 19, 2025
Merged via the queue into main with commit 6f4ffdb Jun 19, 2025
103 checks passed
@erikgrinaker erikgrinaker deleted the erik/grpc-compression branch June 19, 2025 10:02
erikgrinaker added a commit that referenced this pull request Jun 19, 2025
## Problem

The gRPC page service should support compression.

Requires #12111.
Touches #11728.
Touches neondatabase/cloud#25679.

## Summary of changes

Add support for gzip and zstd compression in the server, and a client
parameter to enable compression.

This will need further benchmarking under realistic network conditions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants