-
Notifications
You must be signed in to change notification settings - Fork 848
Create proxy-bench periodic run in CI #12242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8492 tests run: 7911 passed, 0 failed, 581 skipped (full report)Flaky tests (2)Postgres 17
Postgres 14
Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
e612d5b at 2025-06-23T17:15:29.701Z :recycle: |
Currently run for test only via pushing to the test-proxy-bench branch. Relates to the #22681
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can not find some scripts referenced from the workflow in the proxy-bench repo.
Security:
It seems like proxy-bench repo does not require mandatory reviews.
So you are referencing another repo from neon repo and run scripts in that other repo which does not require mandatory reviews - which is a bit insecure.
It would be better if the referenced repo requires same mandatory reviews and checks like the neon repo.
46d2073 to
91ab5a5
Compare
|
@Bodobolero, I fixed the paths, and now proxy-bench requires mandatory review |
Hi, I was notified by github slackbot to review this PR again, however I think we are still discussion metrics collection approach on slack. Pls ping me on slack in DM when this is ready for re-review. |
Bodobolero
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for switching to your own perf test results database.
Currently run for test only via pushing to the test-proxy-bench branch.
Relates to the #22681