Skip to content

Conversation

@awarus
Copy link
Contributor

@awarus awarus commented Jun 13, 2025

Currently run for test only via pushing to the test-proxy-bench branch.

Relates to the #22681

@github-actions
Copy link

github-actions bot commented Jun 13, 2025

8492 tests run: 7911 passed, 0 failed, 581 skipped (full report)


Flaky tests (2)

Postgres 17

Postgres 14

Code coverage* (full report)

  • functions: 32.0% (9034 of 28218 functions)
  • lines: 48.4% (80412 of 166230 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
e612d5b at 2025-06-23T17:15:29.701Z :recycle:
Currently run for test only via pushing to the test-proxy-bench branch.

Relates to the #22681
@awarus awarus changed the title [proxy]: Enable proxy-bench periodic run in CI Enable proxy-bench periodic run in CI Jun 15, 2025
@awarus awarus changed the title Enable proxy-bench periodic run in CI Create proxy-bench periodic run in CI Jun 15, 2025
@awarus awarus marked this pull request as ready for review June 15, 2025 17:33
@awarus awarus requested review from a team as code owners June 15, 2025 17:33
@awarus awarus requested a review from bayandin June 15, 2025 17:33
Copy link
Contributor

@Bodobolero Bodobolero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can not find some scripts referenced from the workflow in the proxy-bench repo.
Security:
It seems like proxy-bench repo does not require mandatory reviews.
So you are referencing another repo from neon repo and run scripts in that other repo which does not require mandatory reviews - which is a bit insecure.
It would be better if the referenced repo requires same mandatory reviews and checks like the neon repo.

@awarus awarus requested a review from Bodobolero June 17, 2025 16:11
@awarus awarus force-pushed the proxy-ci-bench branch 3 times, most recently from 46d2073 to 91ab5a5 Compare June 18, 2025 08:58
@awarus
Copy link
Contributor Author

awarus commented Jun 18, 2025

@Bodobolero, I fixed the paths, and now proxy-bench requires mandatory review

@Bodobolero
Copy link
Contributor

@Bodobolero, I fixed the paths, and now proxy-bench requires mandatory review

Hi, I was notified by github slackbot to review this PR again, however I think we are still discussion metrics collection approach on slack. Pls ping me on slack in DM when this is ready for re-review.

Copy link
Contributor

@Bodobolero Bodobolero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for switching to your own perf test results database.

@awarus awarus enabled auto-merge June 24, 2025 09:40
@awarus awarus added this pull request to the merge queue Jun 24, 2025
Merged via the queue into main with commit a29772b Jun 24, 2025
169 of 171 checks passed
@awarus awarus deleted the proxy-ci-bench branch June 24, 2025 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants