Skip to content

Conversation

@trungda
Copy link
Contributor

@trungda trungda commented Jun 12, 2025

Problem

  • Inside compact_with_gc_inner, there is a similar log line:

    info!(
    "running enhanced gc bottom-most compaction, dry_run={dry_run}, compact_key_range={}..{}, compact_lsn_range={}..{}",
    compact_key_range.start,
    compact_key_range.end,
    compact_lsn_range.start,
    compact_lsn_range.end
    );

  • Also, I think it would be useful when debugging to have the ability to select a particular sub-compaction job (e.g., 1/100) to see all the logs for that job.

Summary of changes

  • Attach a span to the compact_with_gc_inner.

CC: @skyzh

@github-actions github-actions bot added the external A PR or Issue is created by an external user label Jun 12, 2025
@trungda trungda marked this pull request as ready for review June 12, 2025 18:10
@trungda trungda requested a review from a team as a code owner June 12, 2025 18:10
@trungda trungda requested a review from VladLazar June 12, 2025 18:10
@skyzh skyzh added the approved-for-ci-run Changes are safe to trigger CI for the PR label Jun 13, 2025
@github-actions github-actions bot removed the approved-for-ci-run Changes are safe to trigger CI for the PR label Jun 13, 2025
@vipvap vipvap mentioned this pull request Jun 13, 2025
@github-actions
Copy link

8481 tests run: 7899 passed, 0 failed, 582 skipped (full report)


Flaky tests (1)

Postgres 17

Code coverage* (full report)

  • functions: 32.1% (9024 of 28101 functions)
  • lines: 48.4% (80211 of 165716 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
7aba940 at 2025-06-13T04:22:50.876Z :recycle:
@skyzh skyzh added this pull request to the merge queue Jun 13, 2025
Merged via the queue into neondatabase:main with commit 8917676 Jun 13, 2025
157 of 162 checks passed
@trungda trungda deleted the trd/compaction-logging branch June 13, 2025 17:04
@skyzh
Copy link
Contributor

skyzh commented Jun 29, 2025

link to the related issue #11528, thank you for the help on this :)

@trungda
Copy link
Contributor Author

trungda commented Jun 29, 2025

Oh nice! Didn't know there was an issue on this. Let me know if we can help with the original ticket. Also, let me know your thought on this: #12278. We are happy to help (and get help) in this area.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external A PR or Issue is created by an external user

2 participants