Skip to content

Conversation

@skyzh
Copy link
Contributor

@skyzh skyzh commented Jun 2, 2025

Problem

fix #12101; this is a quick hack and we need better API in the future.

In get_db_size, we call get_reldir_size for every relation. However, we do the same deserializing the reldir directory thing for every relation. This creates huge CPU overhead.

Summary of changes

Get and deserialize the reldir v1 key once and use it across all get_rel_size requests.

@skyzh skyzh requested review from erikgrinaker and problame June 2, 2025 11:19
@skyzh skyzh requested a review from a team as a code owner June 2, 2025 11:19
Signed-off-by: Alex Chi Z <[email protected]>
@github-actions
Copy link

github-actions bot commented Jun 2, 2025

8525 tests run: 7942 passed, 0 failed, 583 skipped (full report)


Flaky tests (2)

Postgres 17

Postgres 14

Code coverage* (full report)

  • functions: 32.2% (9046 of 28062 functions)
  • lines: 48.6% (79973 of 164688 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
ec80d90 at 2025-06-03T05:12:34.510Z :recycle:
Signed-off-by: Alex Chi Z <[email protected]>
@skyzh skyzh enabled auto-merge June 3, 2025 04:09
@skyzh skyzh added this pull request to the merge queue Jun 3, 2025
Merged via the queue into main with commit a650f7f Jun 3, 2025
100 checks passed
@skyzh skyzh deleted the skyzh/reldir-deserialize-once branch June 3, 2025 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants