fix(pageserver): only deserialize reldir key once during get_db_size #12102
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
fix #12101; this is a quick hack and we need better API in the future.
In
get_db_size, we callget_reldir_sizefor every relation. However, we do the same deserializing the reldir directory thing for every relation. This creates huge CPU overhead.Summary of changes
Get and deserialize the reldir v1 key once and use it across all get_rel_size requests.