You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Export Multihash as Multihash instead of MultihashGeneric
Rename custom-derive to MultihashDigest: Derives are conventionally named after the trait they implement
Rename serde-codec feature to serde: Use package renames instead
Remove parity-scale-codec dependency? Has a large API surface and is already on major version 3. Doesn't seem to be trust-worthy to not break our API in the future again.
Remove write_multihash and read_multihash from the public API: They are already exposed via Multihash::read and Multihash::write
Rename arb feature to quickcheck: More conventional
The above list are suggestions. Happy to debate all of them. The thinking was:
Reduce and harden API surface
Minimize dependencies
Follow ecosystem conventions
Overall, my suggestion would be to pack all of these into one breaking change which will hopefully be the last one for a long time.
The discussion for how we can stabilize the API of this crate takes place here: #259.
This issue is here to track our progress and link to relevant tasks.
Tasks:
multihash,multihash-codetableandmultihash-derive#266Erroran opaque typeMultihashasMultihashinstead ofMultihashGenericMultihashDigest: Derives are conventionally named after the trait they implementserde-codecfeature to serde: Use package renames insteadparity-scale-codecdependency? Has a large API surface and is already on major version 3. Doesn't seem to be trust-worthy to not break our API in the future again.write_multihashandread_multihashfrom the public API: They are already exposed viaMultihash::readandMultihash::writearbfeature toquickcheck: More conventionalThe above list are suggestions. Happy to debate all of them. The thinking was:
Overall, my suggestion would be to pack all of these into one breaking change which will hopefully be the last one for a long time.