Closed
Description
Hi, I am using this library in deno, and I noticed part of the encode/decode flow checks for the TEXT_ENCODING
environment variable. It seems like this is a useful env var for testing, but I do not need it in production. In deno, I have to allow access to this var explicitly, and will have to tell users of my library to do the same, which feels confusing if this is in fact a testing var. I was wondering if it would be possible to send along a flag like
import * as msgpack from 'npm:@msgpack/msgpack'
msgpack.decode(buffer, { env_check: false })
// or
msgpack.decode(buffer, { text_encoding: false })
for reference, this is the warning deno will share when I do not allow access to env with msgpack.
./test/functional.test.ts (uncaught error)
error: PermissionDenied: Requires env access to "TEXT_ENCODING", run again with the --allow-env flag
return Deno.env.get(name);
^
at Object.getEnv [as get] (deno:runtime/js/30_os.js:86:16)
at denoEnvGet (https://deno.land/[email protected]/node/_process/process.ts:38:21)
at Object.get (https://deno.land/[email protected]/node/_process/process.ts:59:24)
at Object.<anonymous> (file:///home/andrew/.cache/deno/npm/registry.npmjs.org/@msgpack/msgpack/2.8.0/dist/utils/utf8.js:7:177)
at Object.<anonymous> (file:///home/andrew/.cache/deno/npm/registry.npmjs.org/@msgpack/msgpack/2.8.0/dist/utils/utf8.js:168:4)
None of this is really a blocker for using this library, I just believe it could make usage a bit more friendly for the deno audience :)
Metadata
Metadata
Assignees
Labels
No labels