Skip to content

[RELOPS-2325] Remove reboot --force on Ubuntu 24.04 workers #1173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
aerickson wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

[RELOPS-2325] Remove reboot --force on Ubuntu 24.04 workers #1173

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0d75629
Remove reboot --force on Ubuntu 24.04 workers
aerickson Apr 22, 2026
d4dc946
Merge branch 'master' into 042226-linux-reboot-tweaking
aerickson Apr 24, 2026
850472a
Merge branch 'master' into 042226-linux-reboot-tweaking
aerickson May 21, 2026
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Remove reboot --force on Ubuntu 24.04 workers 
--force was added in 2020 (bug 1501936) to fix a systemd hang on 18.04.
On 24.04 + kernel 6.8.0+, bypassing systemd's orderly shutdown causes
silent hangs during driver teardown. Test with graceful reboot on 24.04
while leaving 18.04 behavior unchanged.
  • Loading branch information
@aerickson
aerickson committed Apr 22, 2026
commit 0d75629f90ba6d1b2c72a40a24526752793d0088
23 changes: 9 additions & 14 deletions modules/linux_generic_worker/manifests/init.pp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,21 +69,16 @@
require => Class['packages::linux_generic_worker'];
}

# According to bug 1501936, https://bugzilla.mozilla.org/show_bug.cgi?id=1501936,Linux machines stuck at reboot process.
# Looking over the internet, I found this bug: https://lists.ubuntu.com/archives/foundations-bugs/2016-April/280724.html
# They suspet systemd generate this behavior. I reproduced this by genereting a reboot cron job
# and run it every 10 minutes.
# After around 24 hours the worker stuck at reboot process. I tryed to update systemd to the last version,
# but without success. To fix this, I plan to add --force option to reboot command,
# to shutdown without contacting the system manager.
# According reboot man page:
# -f, --force - Force immediate halt, power-off, or reboot. When specified once,
# this results in an immediate but clean shutdown by the system manager. When specified twice,
# this results in an immediate shutdown without contacting the system manager.
# See the description of --force in systemctl(1) for more details.
# --force was added in 2020 (bug 1501936) to bypass a systemd hang on Ubuntu 18.04.
# On 24.04 workers, --force bypasses systemd's orderly shutdown and appears to cause
# silent hangs during driver teardown (mlx4_en/NVMe) on kernel 6.8.0+.
# Using conditional to test without --force on 24.04 while leaving 18.04 unchanged.
#
# used in run-generic-woker file below
$reboot_command = '/usr/bin/sudo /sbin/reboot --force'
# used in run-generic-worker file below
$reboot_command = $facts['os']['release']['full'] ? {
'24.04' => '/usr/bin/sudo /sbin/reboot',
default => '/usr/bin/sudo /sbin/reboot --force',
}

file {
default:
Expand Down