feat(extensions): support custom syntax grammars - #683
Open
benvinegar wants to merge 2 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Greptile SummaryThe PR adds extension API v3 support for lazily registered Shiki/TextMate syntax grammars and reconciles extension-provided file-language mappings across reloads.
Confidence Score: 5/5The PR appears safe to merge; no concrete, changed-code-triggered defect remains. The registration, application, fallback, cache invalidation, packaging, and public API paths are coordinated and covered by focused tests, with no established blocking or non-blocking failure. Important Files Changed
Sequence DiagramsequenceDiagram
participant E as Extension
participant R as Extension Registry
participant A as Apply Boundary
participant P as Pierre
participant U as Diff UI
E->>R: registerSyntaxLanguage(id, loader)
E->>R: registerFileLanguage(extension, id)
A->>P: register lazy grammar loader
A->>P: replace file-language mappings
U->>P: prepare shared highlighter
P->>E: invoke loader on first use
alt grammar succeeds
P-->>U: highlighted diff
else grammar fails
U->>P: dispose shared highlighter
U->>P: prepare plaintext highlighter
P-->>U: plaintext diff
end
Reviews (1): Last reviewed commit: "feat(extensions): support custom syntax ..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hunk.registerSyntaxLanguage(language, loader)for lazy Shiki/TextMate grammar modulesregisterFileLanguage, reconcile them across reloads, and invalidate cached highlights when the detected language changesThis extracts the reusable extension capability needed by #530 so Odin support can remain a separate language contribution.
Validation
bun run typecheckbun run test— 1,959 passed, 9 skippedbun run test:integration— 97 passedbun run test:tty-smoke— 9 passedbun run lintbun run format:checkbun run check:docsbun run website:checkbun run build:npmbun run check:packbun run changeset:statusThis PR description was generated by Pi using gpt-5.6-sol