Skip to content

[auth] refactor resource selection to not include resource if PRM is not present #693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2025

Conversation

pcarleton
Copy link
Contributor

Motivation and Context

See modelcontextprotocol/inspector#551
see also modelcontextprotocol/python-sdk#991 (comment)

When an MCP server only supports the old specification, we shouldn't include the resource parameter. Ultimately, it's the server's responsibility to enforce resource parameter usage, so if an impersonation attack happens, the server will still be protected by rejecting tokens that don't have a matching included resource, and the server can choose to include PRM to get the resource parameter passed to fix it.

How Has This Been Tested?

Added unit tests

Breaking Changes

No, this will unbreak some servers that would reject an authorization URL with resource in the parameters (e.g. Entra).

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@pcarleton pcarleton requested review from ochafik and ihrpr June 24, 2025 13:52
Copy link
Contributor

@ihrpr ihrpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ihrpr ihrpr merged commit 600c623 into main Jun 24, 2025
5 checks passed
@ihrpr ihrpr deleted the pcarleton/resource-only-when-prm-present branch June 24, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants