[auth] refactor resource selection to not include resource if PRM is not present #693
+241
−17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
See modelcontextprotocol/inspector#551
see also modelcontextprotocol/python-sdk#991 (comment)
When an MCP server only supports the old specification, we shouldn't include the
resource
parameter. Ultimately, it's the server's responsibility to enforceresource
parameter usage, so if an impersonation attack happens, the server will still be protected by rejecting tokens that don't have a matching included resource, and the server can choose to include PRM to get theresource
parameter passed to fix it.How Has This Been Tested?
Added unit tests
Breaking Changes
No, this will unbreak some servers that would reject an authorization URL with
resource
in the parameters (e.g. Entra).Types of changes
Checklist
Additional context