Skip to content

fix: skip validation if tool reports error #655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 24, 2025
Merged

fix: skip validation if tool reports error #655

merged 3 commits into from
Jun 24, 2025
+63 −1

Conversation

Areo-Joe
Copy link

Motivation and Context

#654

How Has This Been Tested?

This PR adds test to ensure the issue is fixed.

Breaking Changes

Nope

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed (no doc needed as I'd expect)

Additional context
ihrpr
ihrpr approved these changes Jun 24, 2025
View reviewed changes
Copy link
Contributor

@ihrpr ihrpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Will apply some nit fixes on top
@ihrpr ihrpr linked an issue Jun 24, 2025 that may be closed by this pull request
Missing or wrong structuredContent blocks tools from reporting error #654
Closed
@ihrpr ihrpr merged commit c401939 into modelcontextprotocol:main Jun 24, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@Areo-Joe @ihrpr