-
Notifications
You must be signed in to change notification settings - Fork 965
Update readme file to include a tip to allow mcp-session-id
in CORS when using StreamableHTTP
#633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for contributing to Typescript SDK!
While the CORS issue is real and documented guidance is needed, the current example has security concerns. The example uses origin: '*'
which is unsafe for production.
Please could you update to use a secure CORS example with specific origins instead of wildcard
Thank you for pointing that out. I completely understand your point. I added that as a quick example, but you're right about the security risks. I'll update it to use a more secure CORS configuration with specific origins instead of a wildcard. |
PR updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Motivation and Context
I think this should be included in the main README, as it’s a unique case and developers might waste a lot of time trying to solve this small issue.
How Has This Been Tested?
N/A
Breaking Changes
N/A
Types of changes
Checklist
Additional context