-
Notifications
You must be signed in to change notification settings - Fork 965
Raw request propagation in tools - passed to callbacks via RequestHandlerExtra<ServerRequest, ServerNotification> #627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raw request propagation in tools - passed to callbacks via RequestHandlerExtra<ServerRequest, ServerNotification> #627
Conversation
Hello, let me know if anything else is needed on this PR. It's been waiting for a couple of weeks, have updated it with the latest from the branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about the delays in review, we are trying to catch up SDK to the latest spec release. Thank you for implementing the suggestions.
Main concern is around onmessage
from optional extra
parameter to required, which breaks existing transport implementations that might not provide this parameter.
@ihrpr updated to reflect comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for the quick turnaround, left some inline comments
…ov/typescript-sdk into request-propagation-in-tools
These are done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
Request Propagation to tool/resource/prompt callbacks via RequestHandlerExtra
This PR is a substitute of the original PR (#557).
Motivation and Context
An application often times needs access to the original request headers, for example, whenever it is sitting behind a reverse proxy, and the reverse proxy is setting some headers itself.
Few real-life examples / use cases:
How Has This Been Tested?
SSE and Streamable transport - resources and tools.
Breaking Changes
No breaking changes.
Types of changes
Checklist
Additional context
Adding the RequestInfo type, which contains just headers for now - to be used for more raw request properties to add as we go - e.g. httpMethod, and others.