[27.x backport] cmd/dockerd: Add workaround for OTEL meter leak #48693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OTEL meter implementation has a memory leak issue which causes each meter counter invocation to create a new instrument when the meter provider is not set. Also add a test, which will fail once a fixed OTEL is vendored. Signed-off-by: Paweł Gronowski <[email protected]> (cherry picked from commit cca7085) Signed-off-by: Paweł Gronowski <[email protected]>
vvoland
added
status/2-code-review
kind/bugfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport: cmd/dockerd: Add workaround for OTEL meter leak #48690
related to: Memory leak caused by
otelhttpwhen no Meter Provider is configured. open-telemetry/opentelemetry-go-contrib#5190probably fixes: Memory Leak in Docker 27.0.3 #48144
OTEL meter implementation has a memory leak issue which causes each meter counter invocation to create a new instrument when the meter provider is not set.
Also add a test, which will fail once a fixed OTEL is vendored.
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)