Allow to enable host loopback and use 10.0.2.2 to connect to the host (OPTIONALLY)#47352
Merged
thaJeztah merged 1 commit intomoby:masterfrom Feb 29, 2024
Merged
Conversation
3c1b8bd to
16ab43d
Compare
AkihiroSuda
reviewed
Feb 8, 2024
Contributor
Author
|
@AkihiroSuda Hello, can you look at it one more time? |
Member
|
Looks good but please squash the commits |
69be0c0 to
86a0829
Compare
Contributor
Author
|
@AkihiroSuda OK, now it squashed. |
Contributor
Author
|
Thank you too |
Contributor
Author
|
Hello @AkihiroSuda does it will be merged or I need something change? |
Member
|
@akerouanton @robmry PTAL |
robmry
approved these changes
Feb 27, 2024
Contributor
robmry
left a comment
There was a problem hiding this comment.
In "Description for the changelog", defaults false needs to be changed to defaults to true.
Otherwise, LGTM.
… (OPTIONALLY) This should allow to enable host loopback by setting DOCKERD_ROOTLESS_ROOTLESSKIT_DISABLE_HOST_LOOPBACK to false, defaults true. Signed-off-by: serhii.n <serhii.n@thescimus.com>
86a0829 to
b649e27
Compare
Contributor
Author
|
@robmry I have updated "Description for the changelog" |
Contributor
Author
|
Thanks to all of you! |
MadLittleMods
added a commit
to matrix-org/complement
that referenced
this pull request
Dec 16, 2025
c.f. `DOCKERD_ROOTLESS_ROOTLESSKIT_NET=slirp4netns` and `DOCKERD_ROOTLESS_ROOTLESSKIT_DISABLE_HOST_LOOPBACK=false` > rootless: Add support for enabling host loopback by setting the `DOCKERD_ROOTLESS_ROOTLESSKIT_DISABLE_HOST_LOOPBACK` environment variable to `false` (defaults to `true`). This lets containers connect to the host by using IP address 10.0.2.2. [moby/moby#47352](moby/moby#47352) > > _-- https://docs.docker.com/engine/release-notes/26.0/_ > ``` > # * DOCKERD_ROOTLESS_ROOTLESSKIT_DISABLE_HOST_LOOPBACK=(true|false): prohibit connections to 127.0.0.1 on the host (including via 10.0.2.2, in the case of slirp4netns). Defaults to "true". > ``` > > *-- https://github.com/moby/moby/blob/b649e272bb0253fe766069966416b9330a2e38c0/contrib/dockerd-rootless.sh#L18*
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
I allow to enable host loopback by setting DOCKERD_ROOTLESS_ROOTLESSKIT_DISABLE_HOST_LOOPBACK to false,
- How I did it
...
- How to verify it
Set DOCKERD_ROOTLESS_ROOTLESSKIT_DISABLE_HOST_LOOPBACK to false and it should allow connections to host by using 10.0.2.2 IP
- Description for the changelog
Allow to enable host loopback by setting DOCKERD_ROOTLESS_ROOTLESSKIT_DISABLE_HOST_LOOPBACK to false, defaults true. It allow to connect to host by using 10.0.2.2 IP
- A picture of a cute animal (not mandatory but encouraged)