frontend/dockerui/build: fix "no scan targets for linux/arm64/v8" #5941
Conversation
tonistiigi
left a comment
tonistiigi
left a comment
There was a problem hiding this comment.
This has broken a couple of times now and I think needs a bigger refactor (can be in follow-up if needed). It isn't even that important what the real key normalization pattern is but the callback and sbom-attach need to always match in their result. I don't think that is still guaranteed even with the current test.
frontend/dockerui/build.go
Outdated
| func normalizePlatform(p, imgP ocispecs.Platform) exptypes.Platform { | ||
| var k string | ||
| if p.OS == "windows" { | ||
| k = platforms.FormatAll(p) |
There was a problem hiding this comment.
Shouldn't this be normalized as well before formatting?
There was a problem hiding this comment.
Didn't change the logic for Windows, as I don't have an env to test the changes
|
@AkihiroSuda I pushed update to https://github.com/moby/buildkit/compare/master...tonistiigi:buildkit:fix-5915?expand=1 but looks like I don't have permissions to push to your PR branch. Making sure ID is always normalized is needed to make sure we match this line https://github.com/moby/buildkit/blob/master/frontend/dockerfile/builder/build.go#L165 |
Signed-off-by: Akihiro Suda <[email protected]>
Fix issue 5915 Signed-off-by: Akihiro Suda <[email protected]>
Make sure key is always normalized and improve tests. Signed-off-by: Tonis Tiigi <[email protected]>
|
Thanks, cherry-picked your commit @tonistiigi |
3 participants
Fix #5915
Test (on ARM):
FROM hello-worldbuildctl build --frontend=dockerfile.v0 --local context=. --local dockerfile=. --opt attest:sbom=