Skip to content

Update Microsoft.Extensions.DependencyModel to 3.1.0#5188

Merged
nohwnd merged 6 commits into
microsoft:mainfrom
nohwnd:update-dependency-model
Sep 11, 2024
Merged

Update Microsoft.Extensions.DependencyModel to 3.1.0#5188
nohwnd merged 6 commits into
microsoft:mainfrom
nohwnd:update-dependency-model

Conversation

@nohwnd

@nohwnd nohwnd commented Aug 27, 2024

Copy link
Copy Markdown
Member

Update to non-deprecated version that is not bringing new dependencies.

@nohwnd

nohwnd commented Sep 10, 2024

Copy link
Copy Markdown
Member Author

@MichaelSimons can you please advise on what I am doing wrong? The previous version was okay with source build.

And please remind me what team I should tag here instead of you specifically, the md says to mention team member https://github.com/dotnet/source-build/blob/main/Documentation/sourcebuild-in-repos/new-dependencies.md#adding-dependencies but the team looks to be internal.

Thank you.

@MichaelSimons

MichaelSimons commented Sep 10, 2024

Copy link
Copy Markdown
Member

@MichaelSimons can you please advise on what I am doing wrong? The previous version was okay with source build.

Because of the Version.Detail.xml dependency, source-build will lift this to the current version. The 3.1.0 version is only reported as a prebuilt in the repo level source-build where lifting does not occur. Because of this, <UsagePattern IdentityGlob="Microsoft.Extensions.DependencyModel/3.1.0*" /> should be added to https://github.com/microsoft/vstest/blob/main/eng/SourceBuildPrebuiltBaseline.xml.

And please remind me what team I should tag here instead of you specifically, the md says to mention team member https://github.com/dotnet/source-build/blob/main/Documentation/sourcebuild-in-repos/new-dependencies.md#adding-dependencies but the team looks to be internal.

https://github.com/orgs/dotnet/teams/source-build-internal is the appropriate team to ping. Apologies, the name is not the best.

@nohwnd nohwnd enabled auto-merge (squash) September 11, 2024 07:19
@nohwnd nohwnd merged commit 96977db into microsoft:main Sep 11, 2024
This was referenced Jul 22, 2025
This was referenced Jul 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants