Add possibility to send telemetry events by data collectors#4622
Merged
Conversation
jakubch1
changed the title
| /// <summary> | ||
| /// Initializes telemetry reporter | ||
| /// </summary> | ||
| void Initialize(ITelemetryReporter telemetryReporter); |
Contributor
There was a problem hiding this comment.
I wonder if we should have an option object for future extensibility but maybe we can add to the ITelemetryReporter self if needed
Member
Author
There was a problem hiding this comment.
I think extending API for extensions is not issue anymore.
| /// </summary> | ||
| /// <param name="name">Telemetry event name</param> | ||
| /// <param name="properties">Telemetry event properties</param> | ||
| public TelemetryEvent(string name, IDictionary<string, object> properties) |
Contributor
There was a problem hiding this comment.
a bit generic but underneath we don't have more than that
Member
Author
There was a problem hiding this comment.
this is API used by VS telemetry
MarcoRossignoli
approved these changes
Jul 31, 2023
MarcoRossignoli
left a comment
MarcoRossignoli
left a comment
Contributor
There was a problem hiding this comment.
some comment but I don't know if we can do better
This was referenced Jul 22, 2025
Merged
This was referenced Jul 7, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please add a meaningful description for this change.
Ensure the PR has required unit tests.
Related issue
Kindly link any related issues. E.g. Fixes #xyz.