Warning on unsupported tfms#15072
Conversation
This reverts commit 81c7638.
Youssef1313
left a comment
Youssef1313
left a comment
There was a problem hiding this comment.
I just wonder if buildMultiTargeting/Microsoft.NET.Test.Sdk.props is split to buildMultiTargeting/net462/Microsoft.NET.Test.Sdk.props and buildMultiTargeting/net8.0/Microsoft.NET.Test.Sdk.props, are we going to get warning/error by NuGet for free? (if not, can you open an issue to NuGet in case it's a bug on their side? - in that case, I'm fine with us implementing the warning/error ourselves)
* Add warning when restoring old TFM * revert * Revert "revert" This reverts commit 81c7638.
@Youssef1313 @nohwnd I have opened a issue and they are currently investigating. |
* Warning on unsupported tfms (#15072) * Add warning when restoring old TFM * revert * Revert "revert" This reverts commit 81c7638. * Make the warning error, and restore previous props so we attempt to run (#15078) * Make the warning error, and restore previous props so we get errors when user suppresses * Update src/package/Microsoft.NET.Test.Sdk/Microsoft.NET.Test.Sdk.nuspec * Correct file count, because we are adding more props * Wrong edit
| <file src="netstandard2.0\Microsoft.NET.Test.Sdk.targets" target="buildMultiTargeting\netcoreapp2.0\" /> | ||
| <file src="netstandard2.0\Microsoft.NET.Test.Sdk.targets" target="build\netcoreapp2.0\" /> | ||
| <file src="netstandard2.0\Microsoft.NET.Test.Sdk.targets" target="buildMultiTargeting\netstandard2.0\" /> | ||
| <file src="netstandard2.0\Microsoft.NET.Test.Sdk.targets" target="build\netstandard2.0\" /> |
There was a problem hiding this comment.
@nohwnd Can you please revisit this?
I think buildMultiTargeting isn't intended to have TFM-specific folders as it's for the outer build (before dispatching to inner builds that actually set the TFM)
4 participants
Description
Write warning when attempting to restore on an unsupported TFM (that is netcoreapp net5, net6, net7 and netstandard).
Fix #15069