Description
When running the System.Text.RegularExpressions.Tests tests in dotnet/runtime, we are seeing an Html Logger error at the end of the test run. I was able to isolate this into a simple repo.
Steps to reproduce
dotnet test the following project:
UnitTest1.cs
using System.Collections.Generic;
using System.Text.RegularExpressions;
using Xunit;
namespace MyTest;
public class UnitTest1
{
public static IEnumerable<object[]> AllMatches_TestData()
{
yield return new object[] { @"(\uFFFE\uFFFF)+", RegexOptions.None, "=====\uFFFE\uFFFF\uFFFE\uFFFF\uFFFE====",
new (int, int, string)[] { (5, 4, "\uFFFE\uFFFF\uFFFE\uFFFF") } };
}
[Theory]
[MemberData(nameof(AllMatches_TestData))]
public void AllMatches(string pattern, RegexOptions options, string input, (int, int, string)[] matches)
{
}
}MyTest.csproj
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>net6.0</TargetFramework>
<Nullable>enable</Nullable>
<RunSettingsFilePath>.runsettings</RunSettingsFilePath>
<IsPackable>false</IsPackable>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.9.4" />
<PackageReference Include="xunit" Version="2.4.1" />
<PackageReference Include="xunit.runner.visualstudio" Version="2.4.3">
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
<PrivateAssets>all</PrivateAssets>
</PackageReference>
<PackageReference Include="coverlet.collector" Version="3.0.2">
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
<PrivateAssets>all</PrivateAssets>
</PackageReference>
</ItemGroup>
</Project>.runsettings
<?xml version="1.0" encoding="utf-8"?>
<RunSettings>
<LoggerRunSettings>
<Loggers>
<Logger friendlyName="html" />
<Logger friendlyName="console">
<Configuration>
<Verbosity>Minimal</Verbosity>
</Configuration>
</Logger>
</Loggers>
</LoggerRunSettings>
</RunSettings>Expected behavior
No errors should be logged
Actual behavior
Test run for /workspaces/DotNetTest/MyTest/bin/Debug/net6.0/MyTest.dll (.NETCoreApp,Version=v6.0)
Microsoft (R) Test Execution Command Line Tool Version 17.0.0-preview-20210817-02
Copyright (c) Microsoft Corporation. All rights reserved.
Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
Html Logger Error : '�', hexadecimal value 0xFFFE, is an invalid character. Line 1, position 448.
Passed! - Failed: 0, Passed: 1, Skipped: 0, Total: 1, Duration: < 1 ms - /workspaces/DotNetTest/MyTest/bin/Debug/net6.0/MyTest.dll (net6.0)
Diagnostic logs
It looks like the exception is coming from around here
|
htmlTransformer.Transform(XmlFilePath, HtmlFilePath); |
|
} |
|
catch (Exception ex) |
|
{ |
|
EqtTrace.Error("HtmlLogger : Failed to populate html file. Exception : {0}", |
|
ex.ToString()); |
|
ConsoleOutput.Instance.Error(false, string.Concat(HtmlResource.HtmlLoggerError), ex.Message); |
|
return; |
Attaching a debugger I see the following stack trace:
System.Private.Xml.dll!System.Xml.XmlTextReaderImpl.Throw(System.Exception e) Line 2822 C#
System.Private.Xml.dll!System.Xml.XmlTextReaderImpl.Throw(string res, string[] args) Line 2796 C#
> System.Private.Xml.dll!System.Xml.XmlTextReaderImpl.ParseNumericCharRefInline(int startPos, bool expand, System.Text.StringBuilder internalSubsetBuilder, out int charCount, out System.Xml.XmlTextReaderImpl.EntityType entityType) Line 7433 C#
System.Private.Xml.dll!System.Xml.XmlTextReaderImpl.ParseCharRefInline(int startPos, out int charCount, out System.Xml.XmlTextReaderImpl.EntityType entityType) Line 7307 C#
System.Private.Xml.dll!System.Xml.XmlTextReaderImpl.ParseText(out int startPos, out int endPos, ref int outOrChars) Line 5687 C#
System.Private.Xml.dll!System.Xml.XmlTextReaderImpl.ParseText() Line 5533 C#
System.Private.Xml.dll!System.Xml.XmlTextReaderImpl.ParseElementContent() Line 4351 C#
System.Private.Xml.dll!System.Xml.XPath.XPathDocument.LoadFromReader(System.Xml.XmlReader reader, System.Xml.XmlSpace space) Line 285 C#
System.Private.Xml.dll!System.Xml.XPath.XPathDocument.XPathDocument(System.Xml.XmlReader reader, System.Xml.XmlSpace space) Line 76 C#
System.Private.Xml.dll!System.Xml.Xsl.Runtime.XmlQueryContext.ConstructDocument(object dataSource, string uriRelative, System.Uri uriResolved) Line 191 C#
System.Private.Xml.dll!System.Xml.Xsl.Runtime.XmlQueryContext.XmlQueryContext(System.Xml.Xsl.Runtime.XmlQueryRuntime runtime, object defaultDataSource, System.Xml.XmlResolver dataSources, System.Xml.Xsl.XsltArgumentList argList, System.Xml.Xsl.Runtime.WhitespaceRuleLookup wsRules) Line 74 C#
System.Private.Xml.dll!System.Xml.Xsl.Runtime.XmlQueryRuntime.XmlQueryRuntime(System.Xml.Xsl.Runtime.XmlQueryStaticData data, object defaultDataSource, System.Xml.XmlResolver dataSources, System.Xml.Xsl.XsltArgumentList argList, System.Xml.Xsl.Runtime.XmlSequenceWriter seqWrt) Line 81 C#
System.Private.Xml.dll!System.Xml.Xsl.XmlILCommand.Execute(object defaultDocument, System.Xml.XmlResolver dataSources, System.Xml.Xsl.XsltArgumentList argumentList, System.Xml.Xsl.Runtime.XmlSequenceWriter results) Line 89 C#
System.Private.Xml.dll!System.Xml.Xsl.XmlILCommand.Execute(object defaultDocument, System.Xml.XmlResolver dataSources, System.Xml.Xsl.XsltArgumentList argumentList, System.Xml.XmlWriter writer) Line 64 C#
System.Private.Xml.dll!System.Xml.Xsl.XslCompiledTransform.Transform(string inputUri, string resultsFile) Line 391 C#
Microsoft.VisualStudio.TestPlatform.Extensions.Html.TestLogger.dll!Microsoft.VisualStudio.TestPlatform.Extensions.HtmlLogger.HtmlTransformer.Transform(string xmlFile, string htmlFile) Line 33 C#
Microsoft.VisualStudio.TestPlatform.Extensions.Html.TestLogger.dll!Microsoft.VisualStudio.TestPlatform.Extensions.HtmlLogger.HtmlLogger.PopulateHtmlFile() Line 331 C#
Microsoft.VisualStudio.TestPlatform.Extensions.Html.TestLogger.dll!Microsoft.VisualStudio.TestPlatform.Extensions.HtmlLogger.HtmlLogger.TestRunCompleteHandler(object sender, Microsoft.VisualStudio.TestPlatform.ObjectModel.Client.TestRunCompleteEventArgs e) Line 309 C#
I assume we need to be escaping some data into the xml file that is getting passed into the XslTransform.
AB#1582509
Description
When running the System.Text.RegularExpressions.Tests tests in dotnet/runtime, we are seeing an Html Logger error at the end of the test run. I was able to isolate this into a simple repo.
Steps to reproduce
dotnet testthe following project:UnitTest1.cs
MyTest.csproj
.runsettings
Expected behavior
No errors should be logged
Actual behavior
Diagnostic logs
It looks like the exception is coming from around here
vstest/src/Microsoft.TestPlatform.Extensions.HtmlLogger/HtmlLogger.cs
Lines 331 to 338 in ad32654
Attaching a debugger I see the following stack trace:
I assume we need to be escaping some data into the xml file that is getting passed into the XslTransform.
AB#1582509